From: Jani Nikula <jani.nikula@linux.intel.com>
To: Markus Heiser <markus.heiser@darmarit.de>
Cc: Johannes Berg <johannes@sipsolutions.net>,
Jonathan Corbet <corbet@lwn.net>,
linux-wireless@vger.kernel.org,
linux-doc <linux-doc@vger.kernel.org>
Subject: Re: sequence diagrams in rst documentation
Date: Wed, 19 Oct 2016 18:17:20 +0300 [thread overview]
Message-ID: <87twc8l667.fsf@intel.com> (raw)
In-Reply-To: <40E20C55-88BE-4639-9901-E4073A07713B@darmarit.de>
On Wed, 19 Oct 2016, Markus Heiser <markus.heiser@darmarit.de> wrote:
> Am 18.10.2016 um 16:52 schrieb Jani Nikula <jani.nikula@linux.intel.com>:
>
>>> *Only* adding the PNG would be awful, I'd have to keep track of the
>>> corresponding source elsewhere, and perhaps couldn't even GPL it
>>> because then I couldn't distribute the PNG without corresponding
>>> source...
>>>
>>> Adding the source text would really be the only practical choice, but
>>> doing so makes it easy to mismatch things, and also very easy to use
>>> proprietary services for it that may go away at any time, etc.
>>
>> Agreed. And there are other problems with attaching binaries (although
>> I'd say we should fix them too) [1].
>>
>> [1] http://lkml.kernel.org/r/02a78907-933d-3f61-572e-28154b16b9e5@redhat.com
>
> Hmm, I was not briefed that binaries are problematic. I have seen
> GIFs e.g. [2] and PDFs with a long history (when I worked with the media
> documentation), so I thought binaries are OK.
>
> Can you give me some more hints to understand in what ways they are
> problematic? / sorry if my question seems dump /
You can download incremental patches from https://www.kernel.org/ for
kernel updates. Seems so 90s, but people apparently still do this. I
don't think the traditional diff/patch tools play ball with
binaries. The least that could be done is to generate the patches using
git diff --binary to include the git binary diff format. I don't see how
that would be worse than having just "Binary files foo and bar differ"
in the diff.
Personally I don't really mind including binaries if they are the
*source* format. If they're generated from something else, that
something else should be tracked in git instead.
And Someone(tm) should fix the tooling to handle binaries...
BR,
Jani.
>
> [2] http://git.kernel.org/cgit/linux/kernel/git/torvalds/linux.git/log/Documentation/DocBook/v4l/fieldseq_tb.gif?h=v3.0
>
> -- Markus --
--
Jani Nikula, Intel Open Source Technology Center
next prev parent reply other threads:[~2016-10-19 15:17 UTC|newest]
Thread overview: 25+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-10-11 12:56 [PATCH] docs-rst: sphinxify 802.11 documentation Johannes Berg
2016-10-11 13:21 ` Jonathan Corbet
2016-10-11 13:30 ` Johannes Berg
2016-10-11 21:39 ` Jonathan Corbet
2016-10-11 22:08 ` Johannes Berg
2016-10-12 17:20 ` Jonathan Corbet
2016-10-11 13:44 ` Johannes Berg
2016-10-11 13:53 ` Johannes Berg
2016-10-18 11:43 ` sequence diagrams in rst documentation Johannes Berg
2016-10-18 13:51 ` Markus Heiser
2016-10-18 14:12 ` Johannes Berg
2016-10-18 14:52 ` Jani Nikula
2016-10-18 19:20 ` Johannes Berg
2016-10-19 15:02 ` Markus Heiser
2016-10-19 15:17 ` Jani Nikula [this message]
2016-10-18 23:52 ` Jonathan Corbet
2016-10-19 7:51 ` Johannes Berg
2016-10-21 12:31 ` Johannes Berg
2016-10-21 12:56 ` Jani Nikula
2016-10-21 13:04 ` Johannes Berg
2016-10-21 16:11 ` Markus Heiser
2016-10-21 21:17 ` Johannes Berg
2016-10-21 21:19 ` Johannes Berg
2016-10-22 16:37 ` Markus Heiser
2016-10-22 20:30 ` Johannes Berg
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=87twc8l667.fsf@intel.com \
--to=jani.nikula@linux.intel.com \
--cc=corbet@lwn.net \
--cc=johannes@sipsolutions.net \
--cc=linux-doc@vger.kernel.org \
--cc=linux-wireless@vger.kernel.org \
--cc=markus.heiser@darmarit.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.