From mboxrd@z Thu Jan  1 00:00:00 1970
From: Eric Anholt <eric@anholt.net>
Subject: Re: [PATCH 2/2] drm: vc4: enable XBGR8888 and ABGR8888 pixel formats
Date: Thu, 07 Jul 2016 18:47:16 -0700
Message-ID: <87twg07vff.fsf@eliezer.anholt.net>
References: <1465507165-16345-1-git-send-email-robh@kernel.org>
 <1465507165-16345-2-git-send-email-robh@kernel.org>
 <87eg85x588.fsf@eliezer.anholt.net>
Mime-Version: 1.0
Content-Type: multipart/mixed; boundary="===============0044918293=="
Return-path: <dri-devel-bounces@lists.freedesktop.org>
Received: from anholt.net (anholt.net [50.246.234.109])
 by gabe.freedesktop.org (Postfix) with ESMTP id 6658F6E805
 for <dri-devel@lists.freedesktop.org>; Fri,  8 Jul 2016 01:47:20 +0000 (UTC)
In-Reply-To: <87eg85x588.fsf@eliezer.anholt.net>
List-Unsubscribe: <https://lists.freedesktop.org/mailman/options/dri-devel>,
 <mailto:dri-devel-request@lists.freedesktop.org?subject=unsubscribe>
List-Archive: <https://lists.freedesktop.org/archives/dri-devel>
List-Post: <mailto:dri-devel@lists.freedesktop.org>
List-Help: <mailto:dri-devel-request@lists.freedesktop.org?subject=help>
List-Subscribe: <https://lists.freedesktop.org/mailman/listinfo/dri-devel>,
 <mailto:dri-devel-request@lists.freedesktop.org?subject=subscribe>
Errors-To: dri-devel-bounces@lists.freedesktop.org
Sender: "dri-devel" <dri-devel-bounces@lists.freedesktop.org>
To: Rob Herring <robh@kernel.org>
Cc: dri-devel@lists.freedesktop.org
List-Id: dri-devel@lists.freedesktop.org

--===============0044918293==
Content-Type: multipart/signed; boundary="=-=-=";
	micalg=pgp-sha512; protocol="application/pgp-signature"

--=-=-=
Content-Type: text/plain

Eric Anholt <eric@anholt.net> writes:

> Rob Herring <robh@kernel.org> writes:
>
>> DRM_FORMAT_XBGR8888 and DRM_FORMAT_ABGR8888 are 2 of the native formats
>> used in Android, so enable them for VC4. There seems to be no logic behind
>> HVS_PIXEL_ORDER_xxxx naming, but HVS_PIXEL_ORDER_ARGB seems to work
>> correctly.
>
> Spent a little bit digging into how the pixel orderings work and didn't
> come up with an answer.  I'll try to look into this one again later.

Never came up with a good answer, but it's rendering correctly in
modetest, so I've reviewed and applied it to drm-vc4-next.

Thanks!

--=-=-=
Content-Type: application/pgp-signature; name="signature.asc"

-----BEGIN PGP SIGNATURE-----
Version: GnuPG v1

iQIcBAEBCgAGBQJXfwYlAAoJELXWKTbR/J7oOCEP/An2/cVCwsGVQ1xvOYlZ1l0V
0Yh0lrS6OqUKKShwbMDMnPjOrocWD02t1+o5xrs8bEs2fLHQzPWn7TLg+hvxcM5c
MNXBhbzohh7BqXQHBsVZjmoEFLdcVlECr1cEfFa9M9Ymg+AbFMN9gJzXffkwlVBr
oeEeCol0V8zQxXWKP+bH75/qzcMDcgVooUbppm5l2Tw4x4WX2mpbmRiN2STYjnIv
cPou5DyTacMNCer8k23IhwbGWDtIFAvgkheSSqSQMztFbMV2nDKwhzDlLuAG1cu1
d3sg+MRY/Ev5r6Swd3l+eUr+MegQ7G3mFovtng3fYvdQBksjFohhF1MJELOK8+dW
/DCeKbivZGgoMQ2xp2WJkc91sosp+eU4lOTazERjDjbwoUXxNJgWzb4Gxko3C7st
5PetZE24UZatS0VmNKU5MULQnA8EuBMVPSYnQXWkTj4hid8HQ5ltcnZIUt5Ux2vX
sIMnyoLb/BhRusBHrnZ8X1wX2CNWUGp6KXGPUZSaGMme3WmrFT94QqH6yIDcxh/N
bR2ChdbarjOjF+uDhHeJSlUOGa7ZtFe9QTTYC8XKLgvMewNacPPClUDj7WLt7W3r
GT84/EYQoq2iz2/m4ytYhx3ZK2jpy3xYTV3QT4uq/WFR13VRGV8JewAtxtKT9GEt
gaNM/8/d+CPBV0kPZdpp
=RQZ2
-----END PGP SIGNATURE-----
--=-=-=--

--===============0044918293==
Content-Type: text/plain; charset="utf-8"
MIME-Version: 1.0
Content-Transfer-Encoding: base64
Content-Disposition: inline

X19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX18KZHJpLWRldmVs
IG1haWxpbmcgbGlzdApkcmktZGV2ZWxAbGlzdHMuZnJlZWRlc2t0b3Aub3JnCmh0dHBzOi8vbGlz
dHMuZnJlZWRlc2t0b3Aub3JnL21haWxtYW4vbGlzdGluZm8vZHJpLWRldmVsCg==

--===============0044918293==--