From mboxrd@z Thu Jan 1 00:00:00 1970 From: Jani Nikula Subject: Re: [PATCH v3] drm/dsi: Implement set tear scanline Date: Tue, 07 Jun 2016 12:02:38 +0300 Message-ID: <87twh55q35.fsf@intel.com> References: <1465285532-12676-1-git-send-email-simhavcs@gmail.com> Mime-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: base64 Return-path: Received: from mga02.intel.com (mga02.intel.com [134.134.136.20]) by gabe.freedesktop.org (Postfix) with ESMTP id AB5FC6E6E2 for ; Tue, 7 Jun 2016 09:02:41 +0000 (UTC) In-Reply-To: <1465285532-12676-1-git-send-email-simhavcs@gmail.com> List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dri-devel-bounces@lists.freedesktop.org Sender: "dri-devel" Cc: open list , "open list:DRM DRIVERS" , Vinay Simha BN , Archit Taneja List-Id: dri-devel@lists.freedesktop.org T24gVHVlLCAwNyBKdW4gMjAxNiwgVmluYXkgU2ltaGEgQk4gPHNpbWhhdmNzQGdtYWlsLmNvbT4g d3JvdGU6Cj4gUHJvdmlkZSBhIHNtYWxsIGNvbnZlbmllbmNlIHdyYXBwZXIgdGhhdCB0cmFuc21p dHMKPiBhIHNldF90ZWFyX3NjYW5saW5lIGNvbW1hbmQuCj4KPiBDYzogQXJjaGl0IFRhbmVqYSA8 YXJjaGl0LnRhbmVqYUBnbWFpbC5jb20+Cj4gQ2M6IEpvaG4gU3R1bHR6IDxqb2huLnN0dWx0ekBs aW5hcm8ub3JnPgo+IENjOiBUaGllcnJ5IFJlZGluZyA8dGhpZXJyeS5yZWRpbmdAZ21haWwuY29t Pgo+IENjOiBTdW1pdCBTZW13YWwgPHN1bWl0LnNlbXdhbEBsaW5hcm8ub3JnPgo+IENjOiBKYW5p IE5pa3VsYSA8amFuaS5uaWt1bGFAbGludXguaW50ZWwuY29tPgo+IFNpZ25lZC1vZmYtYnk6IFZp bmF5IFNpbWhhIEJOIDxzaW1oYXZjc0BnbWFpbC5jb20+CgpSZXZpZXdlZC1ieTogSmFuaSBOaWt1 bGEgPGphbmkubmlrdWxhQGludGVsLmNvbT4KCgo+Cj4gLS0KPiB2MToKPiAgICogaGVscGVyIGZ1 bmN0aW9uIHN1Z2dlc3RlZCBieSBUaGllcnJ5Cj4gICAgIGZvciBzZXRfdGVhcl9zY2FubGluZQo+ ICAgKiBBbHNvIGluY2x1ZGVzIHNtYWxsIGJ1aWxkIGZpeGVzIGZyb20gU3VtaXQgU2Vtd2FsLgo+ Cj4gdjI6Cj4gICAqIG9uZSBzY2FubGluZSBwYXJhbWV0ZXIgc3VnZ2VzdGVkIGJ5IGphbmkKPgo+ IHYzOgo+ICAgKiBwYXNzaW5nIHRoZSBwYXlsb2FkIHByb3Blcmx5IGFzIHN1Z2dlc3RlZCBieSBq YW5pCj4gLS0KPiAtLS0KPiAgZHJpdmVycy9ncHUvZHJtL2RybV9taXBpX2RzaS5jIHwgMjIgKysr KysrKysrKysrKysrKysrKysrKwo+ICBpbmNsdWRlL2RybS9kcm1fbWlwaV9kc2kuaCAgICAgfCAg MSArCj4gIDIgZmlsZXMgY2hhbmdlZCwgMjMgaW5zZXJ0aW9ucygrKQo+Cj4gZGlmZiAtLWdpdCBh L2RyaXZlcnMvZ3B1L2RybS9kcm1fbWlwaV9kc2kuYyBiL2RyaXZlcnMvZ3B1L2RybS9kcm1fbWlw aV9kc2kuYwo+IGluZGV4IGY1ZDgwODMuLjc5MzhjZTcgMTAwNjQ0Cj4gLS0tIGEvZHJpdmVycy9n cHUvZHJtL2RybV9taXBpX2RzaS5jCj4gKysrIGIvZHJpdmVycy9ncHUvZHJtL2RybV9taXBpX2Rz aS5jCj4gQEAgLTk4Myw2ICs5ODMsMjggQEAgaW50IG1pcGlfZHNpX2Rjc19zZXRfdGVhcl9vbihz dHJ1Y3QgbWlwaV9kc2lfZGV2aWNlICpkc2ksCj4gIEVYUE9SVF9TWU1CT0wobWlwaV9kc2lfZGNz X3NldF90ZWFyX29uKTsKPiAgCj4gIC8qKgo+ICsgKiBtaXBpX2RzaV9zZXRfdGVhcl9zY2FubGlu ZSgpIC0gdHVybiBvbiB0aGUgZGlzcGxheSBtb2R1bGUncyBUZWFyaW5nIEVmZmVjdAo+ICsgKiBv dXRwdXQgc2lnbmFsIG9uIHRoZSBURSBzaWduYWwgbGluZSB3aGVuIGRpc3BsYXkgbW9kdWxlIHJl YWNoZXMgbGluZSBOCj4gKyAqIGRlZmluZWQgYnkgU1RTW246MF0uCj4gKyAqIEBkc2k6IERTSSBw ZXJpcGhlcmFsIGRldmljZQo+ICsgKiBAcGFyYW06IFNUU1sxMDowXQo+ICsgKiBSZXR1cm46IDAg b24gc3VjY2VzcyBvciBhIG5lZ2F0aXZlIGVycm9yIGNvZGUgb24gZmFpbHVyZQo+ICsgKi8KPiAr aW50IG1pcGlfZHNpX3NldF90ZWFyX3NjYW5saW5lKHN0cnVjdCBtaXBpX2RzaV9kZXZpY2UgKmRz aSwgdTE2IHBhcmFtKQo+ICt7Cj4gKwl1OCBwYXlsb2FkWzNdID0geyBNSVBJX0RDU19TRVRfVEVB Ul9TQ0FOTElORSwgcGFyYW0gPj4gOCwKPiArCQkJICBwYXJhbSAmIDB4ZmYgfTsKPiArCXNzaXpl X3QgZXJyOwo+ICsKPiArCWVyciA9IG1pcGlfZHNpX2dlbmVyaWNfd3JpdGUoZHNpLCBwYXlsb2Fk LCBzaXplb2YocGF5bG9hZCkpOwo+ICsJaWYgKGVyciA8IDApCj4gKwkJcmV0dXJuIGVycjsKPiAr Cj4gKwlyZXR1cm4gMDsKPiArfQo+ICtFWFBPUlRfU1lNQk9MKG1pcGlfZHNpX3NldF90ZWFyX3Nj YW5saW5lKTsKPiArCj4gKy8qKgo+ICAgKiBtaXBpX2RzaV9kY3Nfc2V0X3BpeGVsX2Zvcm1hdCgp IC0gc2V0cyB0aGUgcGl4ZWwgZm9ybWF0IGZvciB0aGUgUkdCIGltYWdlCj4gICAqICAgIGRhdGEg dXNlZCBieSB0aGUgaW50ZXJmYWNlCj4gICAqIEBkc2k6IERTSSBwZXJpcGhlcmFsIGRldmljZQo+ IGRpZmYgLS1naXQgYS9pbmNsdWRlL2RybS9kcm1fbWlwaV9kc2kuaCBiL2luY2x1ZGUvZHJtL2Ry bV9taXBpX2RzaS5oCj4gaW5kZXggN2E5ODQwZi4uZWM1NTI4NSAxMDA2NDQKPiAtLS0gYS9pbmNs dWRlL2RybS9kcm1fbWlwaV9kc2kuaAo+ICsrKyBiL2luY2x1ZGUvZHJtL2RybV9taXBpX2RzaS5o Cj4gQEAgLTI2Myw2ICsyNjMsNyBAQCBpbnQgbWlwaV9kc2lfZGNzX3NldF9jb2x1bW5fYWRkcmVz cyhzdHJ1Y3QgbWlwaV9kc2lfZGV2aWNlICpkc2ksIHUxNiBzdGFydCwKPiAgCQkJCSAgICB1MTYg ZW5kKTsKPiAgaW50IG1pcGlfZHNpX2Rjc19zZXRfcGFnZV9hZGRyZXNzKHN0cnVjdCBtaXBpX2Rz aV9kZXZpY2UgKmRzaSwgdTE2IHN0YXJ0LAo+ICAJCQkJICB1MTYgZW5kKTsKPiAraW50IG1pcGlf ZHNpX3NldF90ZWFyX3NjYW5saW5lKHN0cnVjdCBtaXBpX2RzaV9kZXZpY2UgKmRzaSwgdTE2IHBh cmFtKTsKPiAgaW50IG1pcGlfZHNpX2Rjc19zZXRfdGVhcl9vZmYoc3RydWN0IG1pcGlfZHNpX2Rl dmljZSAqZHNpKTsKPiAgaW50IG1pcGlfZHNpX2Rjc19zZXRfdGVhcl9vbihzdHJ1Y3QgbWlwaV9k c2lfZGV2aWNlICpkc2ksCj4gIAkJCSAgICAgZW51bSBtaXBpX2RzaV9kY3NfdGVhcl9tb2RlIG1v ZGUpOwoKLS0gCkphbmkgTmlrdWxhLCBJbnRlbCBPcGVuIFNvdXJjZSBUZWNobm9sb2d5IENlbnRl cgpfX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fXwpkcmktZGV2 ZWwgbWFpbGluZyBsaXN0CmRyaS1kZXZlbEBsaXN0cy5mcmVlZGVza3RvcC5vcmcKaHR0cHM6Ly9s aXN0cy5mcmVlZGVza3RvcC5vcmcvbWFpbG1hbi9saXN0aW5mby9kcmktZGV2ZWwK From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S932180AbcFGJDI (ORCPT ); Tue, 7 Jun 2016 05:03:08 -0400 Received: from mga14.intel.com ([192.55.52.115]:36851 "EHLO mga14.intel.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1754687AbcFGJCm (ORCPT ); Tue, 7 Jun 2016 05:02:42 -0400 X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.26,432,1459839600"; d="scan'208";a="996803675" From: Jani Nikula To: Vinay Simha BN Cc: Vinay Simha BN , Archit Taneja , John Stultz , Thierry Reding , Sumit Semwal , David Airlie , "open list\:DRM DRIVERS" , open list Subject: Re: [PATCH v3] drm/dsi: Implement set tear scanline In-Reply-To: <1465285532-12676-1-git-send-email-simhavcs@gmail.com> Organization: Intel Finland Oy - BIC 0357606-4 - Westendinkatu 7, 02160 Espoo References: <1465285532-12676-1-git-send-email-simhavcs@gmail.com> User-Agent: Notmuch/0.22+12~gbdd9442 (http://notmuchmail.org) Emacs/24.4.1 (x86_64-pc-linux-gnu) Date: Tue, 07 Jun 2016 12:02:38 +0300 Message-ID: <87twh55q35.fsf@intel.com> MIME-Version: 1.0 Content-Type: text/plain Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Tue, 07 Jun 2016, Vinay Simha BN wrote: > Provide a small convenience wrapper that transmits > a set_tear_scanline command. > > Cc: Archit Taneja > Cc: John Stultz > Cc: Thierry Reding > Cc: Sumit Semwal > Cc: Jani Nikula > Signed-off-by: Vinay Simha BN Reviewed-by: Jani Nikula > > -- > v1: > * helper function suggested by Thierry > for set_tear_scanline > * Also includes small build fixes from Sumit Semwal. > > v2: > * one scanline parameter suggested by jani > > v3: > * passing the payload properly as suggested by jani > -- > --- > drivers/gpu/drm/drm_mipi_dsi.c | 22 ++++++++++++++++++++++ > include/drm/drm_mipi_dsi.h | 1 + > 2 files changed, 23 insertions(+) > > diff --git a/drivers/gpu/drm/drm_mipi_dsi.c b/drivers/gpu/drm/drm_mipi_dsi.c > index f5d8083..7938ce7 100644 > --- a/drivers/gpu/drm/drm_mipi_dsi.c > +++ b/drivers/gpu/drm/drm_mipi_dsi.c > @@ -983,6 +983,28 @@ int mipi_dsi_dcs_set_tear_on(struct mipi_dsi_device *dsi, > EXPORT_SYMBOL(mipi_dsi_dcs_set_tear_on); > > /** > + * mipi_dsi_set_tear_scanline() - turn on the display module's Tearing Effect > + * output signal on the TE signal line when display module reaches line N > + * defined by STS[n:0]. > + * @dsi: DSI peripheral device > + * @param: STS[10:0] > + * Return: 0 on success or a negative error code on failure > + */ > +int mipi_dsi_set_tear_scanline(struct mipi_dsi_device *dsi, u16 param) > +{ > + u8 payload[3] = { MIPI_DCS_SET_TEAR_SCANLINE, param >> 8, > + param & 0xff }; > + ssize_t err; > + > + err = mipi_dsi_generic_write(dsi, payload, sizeof(payload)); > + if (err < 0) > + return err; > + > + return 0; > +} > +EXPORT_SYMBOL(mipi_dsi_set_tear_scanline); > + > +/** > * mipi_dsi_dcs_set_pixel_format() - sets the pixel format for the RGB image > * data used by the interface > * @dsi: DSI peripheral device > diff --git a/include/drm/drm_mipi_dsi.h b/include/drm/drm_mipi_dsi.h > index 7a9840f..ec55285 100644 > --- a/include/drm/drm_mipi_dsi.h > +++ b/include/drm/drm_mipi_dsi.h > @@ -263,6 +263,7 @@ int mipi_dsi_dcs_set_column_address(struct mipi_dsi_device *dsi, u16 start, > u16 end); > int mipi_dsi_dcs_set_page_address(struct mipi_dsi_device *dsi, u16 start, > u16 end); > +int mipi_dsi_set_tear_scanline(struct mipi_dsi_device *dsi, u16 param); > int mipi_dsi_dcs_set_tear_off(struct mipi_dsi_device *dsi); > int mipi_dsi_dcs_set_tear_on(struct mipi_dsi_device *dsi, > enum mipi_dsi_dcs_tear_mode mode); -- Jani Nikula, Intel Open Source Technology Center