From: Stewart Smith <stewart@linux.vnet.ibm.com>
To: Sam Mendoza-Jonas <sam@mendozajonas.com>,
Russell Currey <ruscur@russell.cc>
Cc: linuxppc-dev@lists.ozlabs.org, Gavin Shan <gwshan@linux.vnet.ibm.com>
Subject: Re: [PATCH] powerpc/eeh: Fix PE location code
Date: Thu, 21 Jan 2016 16:59:17 +1100 [thread overview]
Message-ID: <87twm75v7u.fsf@linux.vnet.ibm.com> (raw)
In-Reply-To: <20160121000842.GB10361@localhost.localdomain>
Sam Mendoza-Jonas <sam@mendozajonas.com> writes:
> On Wed, Jan 20, 2016 at 02:56:13PM +1100, Russell Currey wrote:
>> On Wed, 2015-12-02 at 16:25 +1100, Gavin Shan wrote:
>> > In eeh_pe_loc_get(), the PE location code is retrieved from the
>> > "ibm,loc-code" property of the device node for the bridge of the
>> > PE's primary bus. It's not correct because the property indicates
>> > the parent PE's location code.
>> >
>> > This reads the correct PE location code from "ibm,io-base-loc-code"
>> > or "ibm,slot-location-code" property of PE parent bus's device node.
>> >
>> > Signed-off-by: Gavin Shan <gwshan@linux.vnet.ibm.com>
>> > ---
>>
>> Tested-by: Russell Currey <ruscur@russell.cc>
>
> Thanks Russell!
>
> W.R.T including this in stable, I don't believe anything actively breaks
> without the patch, but in the event of an EEH freeze the wrong slot for
> the device will be identified, making troubleshooting more difficult.
As someone who's likely going to have to deal with the bug reports for
such things, I like the idea of this going to stable as *maybe* I'll get
fewer of them that I have to close pointing to this commit...
--
Stewart Smith
OPAL Architect, IBM.
next prev parent reply other threads:[~2016-01-21 5:59 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-12-02 5:25 [PATCH] powerpc/eeh: Fix PE location code Gavin Shan
2016-01-19 22:41 ` Joel Stanley
2016-01-20 3:56 ` Russell Currey
2016-01-21 0:08 ` Sam Mendoza-Jonas
2016-01-21 5:59 ` Stewart Smith [this message]
2016-01-29 1:58 ` Michael Ellerman
-- strict thread matches above, loose matches on Subject: below --
2015-12-02 5:17 [PATCH] " Gavin Shan
2015-12-02 5:41 ` Gavin Shan
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=87twm75v7u.fsf@linux.vnet.ibm.com \
--to=stewart@linux.vnet.ibm.com \
--cc=gwshan@linux.vnet.ibm.com \
--cc=linuxppc-dev@lists.ozlabs.org \
--cc=ruscur@russell.cc \
--cc=sam@mendozajonas.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.