From: Jani Nikula <jani.nikula@intel.com>
To: "Ville Syrjälä" <ville.syrjala@linux.intel.com>,
"Daniel Stone" <daniels@collabora.com>
Cc: intel-gfx@lists.freedesktop.org, ville.syrjala@intel.com
Subject: Re: [PATCH v2 2/2] drm/i915/pm: Print offending domain in refcount failure
Date: Mon, 23 Nov 2015 12:31:05 +0200 [thread overview]
Message-ID: <87twod80t2.fsf@intel.com> (raw)
In-Reply-To: <20151120160353.GU4437@intel.com>
On Fri, 20 Nov 2015, Ville Syrjälä <ville.syrjala@linux.intel.com> wrote:
> On Fri, Nov 20, 2015 at 03:55:34PM +0000, Daniel Stone wrote:
>> If we experience a refcounting failure in a power domain/well (unref'ing at
>> least one too many times), log the name of the offending domain or well.
>>
>> Signed-off-by: Daniel Stone <daniels@collabora.com>
>
> Both patches look OK to me
> Reviewed-by: Ville Syrjälä <ville.syrjala@linux.intel.com>
Acked-by: Jani Nikula <jani.nikula@intel.com>
>
>> ---
>> drivers/gpu/drm/i915/intel_runtime_pm.c | 8 ++++++--
>> 1 file changed, 6 insertions(+), 2 deletions(-)
>>
>> diff --git a/drivers/gpu/drm/i915/intel_runtime_pm.c b/drivers/gpu/drm/i915/intel_runtime_pm.c
>> index 754f9bd..7237dea 100644
>> --- a/drivers/gpu/drm/i915/intel_runtime_pm.c
>> +++ b/drivers/gpu/drm/i915/intel_runtime_pm.c
>> @@ -1499,11 +1499,15 @@ void intel_display_power_put(struct drm_i915_private *dev_priv,
>>
>> mutex_lock(&power_domains->lock);
>>
>> - WARN_ON(!power_domains->domain_use_count[domain]);
>> + WARN(!power_domains->domain_use_count[domain],
>> + "Use count on domain %s is already zero\n",
>> + intel_display_power_domain_str(domain));
>> power_domains->domain_use_count[domain]--;
>>
>> for_each_power_well_rev(i, power_well, BIT(domain), power_domains) {
>> - WARN_ON(!power_well->count);
>> + WARN(!power_well->count,
>> + "Use count on power well %s is already zero",
>> + power_well->name);
>>
>> if (!--power_well->count)
>> intel_power_well_disable(dev_priv, power_well);
>> --
>> 2.5.0
>>
>> _______________________________________________
>> Intel-gfx mailing list
>> Intel-gfx@lists.freedesktop.org
>> http://lists.freedesktop.org/mailman/listinfo/intel-gfx
--
Jani Nikula, Intel Open Source Technology Center
_______________________________________________
Intel-gfx mailing list
Intel-gfx@lists.freedesktop.org
http://lists.freedesktop.org/mailman/listinfo/intel-gfx
next prev parent reply other threads:[~2015-11-23 10:27 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-11-20 15:55 [PATCH v2 1/2] drm/i915/pm: Unstatic power_domain_str Daniel Stone
2015-11-20 15:55 ` [PATCH v2 2/2] drm/i915/pm: Print offending domain in refcount failure Daniel Stone
2015-11-20 16:03 ` Ville Syrjälä
2015-11-23 10:31 ` Jani Nikula [this message]
2015-11-23 15:12 ` Imre Deak
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=87twod80t2.fsf@intel.com \
--to=jani.nikula@intel.com \
--cc=daniels@collabora.com \
--cc=intel-gfx@lists.freedesktop.org \
--cc=ville.syrjala@intel.com \
--cc=ville.syrjala@linux.intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.