From mboxrd@z Thu Jan  1 00:00:00 1970
Received: from eggs.gnu.org ([2001:4830:134:3::10]:47555)
	by lists.gnu.org with esmtp (Exim 4.71)
	(envelope-from <armbru@redhat.com>) id 1ZjoSV-0000j7-PC
	for qemu-devel@nongnu.org; Wed, 07 Oct 2015 09:08:40 -0400
Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71)
	(envelope-from <armbru@redhat.com>) id 1ZjoSR-0000Zh-PZ
	for qemu-devel@nongnu.org; Wed, 07 Oct 2015 09:08:39 -0400
Received: from mx1.redhat.com ([209.132.183.28]:38062)
	by eggs.gnu.org with esmtp (Exim 4.71)
	(envelope-from <armbru@redhat.com>) id 1ZjoSR-0000ZX-Kw
	for qemu-devel@nongnu.org; Wed, 07 Oct 2015 09:08:35 -0400
From: Markus Armbruster <armbru@redhat.com>
References: <8737xylxce.fsf@blackfin.pond.sub.org>
	<1444165843-3695-1-git-send-email-eblake@redhat.com>
	<877fmydh22.fsf@blackfin.pond.sub.org>
Date: Wed, 07 Oct 2015 15:08:32 +0200
In-Reply-To: <877fmydh22.fsf@blackfin.pond.sub.org> (Markus Armbruster's
	message of "Wed, 07 Oct 2015 14:00:37 +0200")
Message-ID: <87twq27rn3.fsf@blackfin.pond.sub.org>
MIME-Version: 1.0
Content-Type: text/plain
Subject: Re: [Qemu-devel] [RFC PATCH] qapi: split visit_end_struct() into
	pieces
List-Id: <qemu-devel.nongnu.org>
List-Unsubscribe: <https://lists.nongnu.org/mailman/options/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=unsubscribe>
List-Archive: <http://lists.nongnu.org/archive/html/qemu-devel>
List-Post: <mailto:qemu-devel@nongnu.org>
List-Help: <mailto:qemu-devel-request@nongnu.org?subject=help>
List-Subscribe: <https://lists.nongnu.org/mailman/listinfo/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=subscribe>
To: Eric Blake <eblake@redhat.com>
Cc: "Michael S. Tsirkin" <mst@redhat.com>, qemu-devel@nongnu.org, Michael Roth <mdroth@linux.vnet.ibm.com>, Luiz Capitulino <lcapitulino@redhat.com>, Paolo Bonzini <pbonzini@redhat.com>, Andreas =?utf-8?Q?F=C3=A4rber?= <afaerber@suse.de>

Markus Armbruster <armbru@redhat.com> writes:

> Eric Blake <eblake@redhat.com> writes:
[...]
>> diff --git a/hw/virtio/virtio-balloon.c b/hw/virtio/virtio-balloon.c
>> index c419b17..48867c4 100644
>> --- a/hw/virtio/virtio-balloon.c
>> +++ b/hw/virtio/virtio-balloon.c
>> @@ -132,14 +132,16 @@ static void balloon_stats_get_all(Object *obj, struct Visitor *v,
>        visit_start_struct(v, NULL, NULL, "stats", 0, &err);
>        if (err) {
>            goto out_end;
>        }
>        for (i = 0; !err && i < VIRTIO_BALLOON_S_NR; i++) {
>>          visit_type_int64(v, (int64_t *) &s->stats[i], balloon_stat_names[i],
>>                           &err);
>
> Preexisting: if visit_type_int64() fails, we need to break the loop.
> Separate fix.

Nonsense.

[...]