From mboxrd@z Thu Jan  1 00:00:00 1970
From: Alex =?utf-8?Q?Benn=C3=A9e?= <alex.bennee@linaro.org>
Subject: Re: [kvm-unit-tests PATCH 7/7] arm/run: add --debug option
Date: Tue, 07 Jul 2015 07:45:49 +0100
Message-ID: <87twtga2jm.fsf@linaro.org>
References: <1435931327-8073-1-git-send-email-alex.bennee@linaro.org> <1435931327-8073-8-git-send-email-alex.bennee@linaro.org> <20150706131406.GH17217@hawk.localdomain>
Mime-Version: 1.0
Content-Type: text/plain; charset=utf-8
Content-Transfer-Encoding: QUOTED-PRINTABLE
Cc: kvm@vger.kernel.org
To: Andrew Jones <drjones@redhat.com>
Return-path: <kvm-owner@vger.kernel.org>
Received: from mail-wg0-f50.google.com ([74.125.82.50]:33509 "EHLO
	mail-wg0-f50.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org
	with ESMTP id S1753438AbbGGGpz (ORCPT <rfc822;kvm@vger.kernel.org>);
	Tue, 7 Jul 2015 02:45:55 -0400
Received: by wgck11 with SMTP id k11so158770253wgc.0
        for <kvm@vger.kernel.org>; Mon, 06 Jul 2015 23:45:52 -0700 (PDT)
In-reply-to: <20150706131406.GH17217@hawk.localdomain>
Sender: kvm-owner@vger.kernel.org
List-ID: <kvm.vger.kernel.org>


Andrew Jones <drjones@redhat.com> writes:

> On Fri, Jul 03, 2015 at 02:48:47PM +0100, Alex Benn=C3=A9e wrote:
>> This allows you to pass debug options through to the QEMU command li=
ne.
>> e.g.:
>>=20
>>   ./arm/run --debug "-name debug-threads=3Don" -- arm/vos-spinlock-t=
est.flat -smp 4
>
> doesn't
> ./arm/run arm/vos-spinlock-test.flat -smp 4 -name debug-threads=3Don
> do the same thing?

You are right of course, I forgot you needed an explict -append for the
args to the test anyway.

>
>>=20
>> Signed-off-by: Alex Benn=C3=A9e <alex.bennee@linaro.org>
>> ---
>>  arm/run | 7 ++++++-
>>  1 file changed, 6 insertions(+), 1 deletion(-)
>>=20
>> diff --git a/arm/run b/arm/run
>> index 43d7508..871e35e 100755
>> --- a/arm/run
>> +++ b/arm/run
>> @@ -18,10 +18,15 @@ if [ -c /dev/kvm ]; then
>>  	fi
>>  fi
>> =20
>> +debugopts=3D""
>>  while :; do
>>  	case $1 in
>>  		--force-tcg)
>>  			usingkvm=3D0
>> +			;;
>> +		--debug)
>> +			shift
>> +			debugopts=3D$1
>>  			shift
>>  			;;
>>  		--)
>> @@ -78,7 +83,7 @@ if [ $usingkvm =3D 1 ] && [ "$ARCH" =3D "arm64" ];=
 then
>>  fi
>> =20
>>  command=3D"$qemu $M -cpu $processor $chr_testdev"
>> -command+=3D" -display none -serial stdio -kernel"
>> +command+=3D" -display none -serial stdio $debugopts -kernel"
>> =20
>>  echo $command "$@"
>>  $command "$@"
>> --=20
>> 2.4.5
>>=20
>> --
>> To unsubscribe from this list: send the line "unsubscribe kvm" in
>> the body of a message to majordomo@vger.kernel.org
>> More majordomo info at  http://vger.kernel.org/majordomo-info.html

--=20
Alex Benn=C3=A9e