From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([2001:4830:134:3::10]:42399) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1Z0oSJ-0001Iu-2E for qemu-devel@nongnu.org; Fri, 05 Jun 2015 06:02:28 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1Z0oSE-0006bd-3s for qemu-devel@nongnu.org; Fri, 05 Jun 2015 06:02:27 -0400 Received: from e28smtp08.in.ibm.com ([122.248.162.8]:35940) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1Z0oSD-0006YS-GQ for qemu-devel@nongnu.org; Fri, 05 Jun 2015 06:02:22 -0400 Received: from /spool/local by e28smtp08.in.ibm.com with IBM ESMTP SMTP Gateway: Authorized Use Only! Violators will be prosecuted for from ; Fri, 5 Jun 2015 15:32:16 +0530 From: Nikunj A Dadhania In-Reply-To: <1433495103-62084-1-git-send-email-agraf@suse.de> References: <1433495103-62084-1-git-send-email-agraf@suse.de> Date: Fri, 05 Jun 2015 15:32:02 +0530 Message-ID: <87twuma2xx.fsf@linux.vnet.ibm.com> MIME-Version: 1.0 Content-Type: text/plain Subject: Re: [Qemu-devel] [PATCH] machine: Drop use of DEFAULT_RAM_SIZE in help text List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: Alexander Graf , qemu-devel@nongnu.org Cc: laurent.desnogues@gmail.com, peter.maydell@linaro.org, qemu-ppc@nongnu.org, david@gibson.dropbear.id.au Alexander Graf writes: > As of commit 076b35b5a (machine: add default_ram_size to machine class) we > no longer have a global default ram size, but instead machine specific > defaults. When invoking qemu --help we don't know which machine you selected, > so we can't tell the user the default RAM size in the help text anymore now. > > Thus I don't see an easy way to expose the default ram size to the user in the > help text. The easiest option IMHO is to just drop this piece of information. Acked-by: Nikunj A Dadhania > Reported-by: Laurent Desnogues > Signed-off-by: Alexander Graf > > --- > qemu-options.hx | 3 +-- > 1 file changed, 1 insertion(+), 2 deletions(-) > > diff --git a/qemu-options.hx b/qemu-options.hx > index b3db6cb..5eaba11 100644 > --- a/qemu-options.hx > +++ b/qemu-options.hx > @@ -241,8 +241,7 @@ ETEXI > DEF("m", HAS_ARG, QEMU_OPTION_m, > "-m[emory] [size=]megs[,slots=n,maxmem=size]\n" > " configure guest RAM\n" > - " size: initial amount of guest memory (default: " > - stringify(DEFAULT_RAM_SIZE) "MiB)\n" > + " size: initial amount of guest memory\n" > " slots: number of hotplug slots (default: none)\n" > " maxmem: maximum amount of guest memory (default: none)\n" > "NOTE: Some architectures might enforce a specific granularity\n", > -- > 1.8.1.4