From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([2001:4830:134:3::10]:43570) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1YqdZE-0006zu-HE for qemu-devel@nongnu.org; Fri, 08 May 2015 04:23:33 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1YqdZA-0001Qv-BS for qemu-devel@nongnu.org; Fri, 08 May 2015 04:23:32 -0400 Received: from mx1.redhat.com ([209.132.183.28]:58944) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1YqdZA-0001Q0-3e for qemu-devel@nongnu.org; Fri, 08 May 2015 04:23:28 -0400 From: Juan Quintela In-Reply-To: <554B9E76.7060504@redhat.com> (Paolo Bonzini's message of "Thu, 07 May 2015 19:18:46 +0200") References: <1431017176-3301-1-git-send-email-quintela@redhat.com> <1431017176-3301-6-git-send-email-quintela@redhat.com> <554B9E76.7060504@redhat.com> Date: Fri, 08 May 2015 10:23:23 +0200 Message-ID: <87twvnv5ok.fsf@neno.neno> MIME-Version: 1.0 Content-Type: text/plain Subject: Re: [Qemu-devel] [PULL 05/16] arch_init: Alloc and free data struct for compression Reply-To: quintela@redhat.com List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: Paolo Bonzini Cc: Yang Zhang , Liang Li , qemu-devel@nongnu.org Paolo Bonzini wrote: > On 07/05/2015 18:46, Juan Quintela wrote: >> static CompressParam *comp_param; >> static QemuThread *compress_threads; >> +/* comp_done_cond is used to wake up the migration thread when >> + * one of the compression threads has finished the compression. >> + * comp_done_lock is used to co-work with comp_done_cond. >> + */ >> +static QemuMutex *comp_done_lock; >> +static QemuCond *comp_done_cond; > > Can you please putr these (and the corresponding globals for > decompression) in a struct? Added to ToDo list if Liang don't de it first. Later, Juan.