From mboxrd@z Thu Jan 1 00:00:00 1970 From: Alex =?utf-8?Q?Benn=C3=A9e?= Subject: Re: [PATCH v2] target-arm: Store SPSR_EL1 state in banked_spsr[1] (SPSR_svc) Date: Wed, 18 Mar 2015 13:58:40 +0000 Message-ID: <87twxis8z3.fsf@linaro.org> References: <1426620735-2454-1-git-send-email-peter.maydell@linaro.org> <20150317193816.GB23225@cbox> Mime-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: base64 Return-path: Received: from localhost (localhost [127.0.0.1]) by mm01.cs.columbia.edu (Postfix) with ESMTP id DD06449046 for ; Wed, 18 Mar 2015 09:51:43 -0400 (EDT) Received: from mm01.cs.columbia.edu ([127.0.0.1]) by localhost (mm01.cs.columbia.edu [127.0.0.1]) (amavisd-new, port 10024) with ESMTP id biU79aHJcOLb for ; Wed, 18 Mar 2015 09:51:42 -0400 (EDT) Received: from socrates.bennee.com (static.88-198-71-155.clients.your-server.de [88.198.71.155]) by mm01.cs.columbia.edu (Postfix) with ESMTPS id 9DFC649045 for ; Wed, 18 Mar 2015 09:51:41 -0400 (EDT) In-reply-to: <20150317193816.GB23225@cbox> List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: kvmarm-bounces@lists.cs.columbia.edu Sender: kvmarm-bounces@lists.cs.columbia.edu To: Christoffer Dall Cc: Greg Bellows , kvmarm@lists.cs.columbia.edu, qemu-devel@nongnu.org, patches@linaro.org List-Id: kvmarm@lists.cs.columbia.edu CkNocmlzdG9mZmVyIERhbGwgPGNocmlzdG9mZmVyLmRhbGxAbGluYXJvLm9yZz4gd3JpdGVzOgoK PiBPbiBUdWUsIE1hciAxNywgMjAxNSBhdCAwNzozMjoxNVBNICswMDAwLCBQZXRlciBNYXlkZWxs IHdyb3RlOgo+PiBUaGUgQUFyY2g2NCBTUFNSX0VMMSByZWdpc3RlciBpcyBhcmNoaXRlY3R1cmFs bHkgbWFuZGF0ZWQgdG8KPj4gYmUgbWFwcGVkIHRvIHRoZSBBQXJjaDMyIFNQU1Jfc3ZjIHJlZ2lz dGVyLiBUaGlzIG1lYW5zIGl0cwo+PiBzdGF0ZSBzaG91bGQgbGl2ZSBpbiBRRU1VJ3MgZW52LT5i YW5rZWRfc3BzclsxXSBmaWVsZC4KPj4gQ29ycmVjdCB0aGUgdmFyaW91cyBwbGFjZXMgaW4gdGhl IGNvZGUgdGhhdCBpbmNvcnJlY3RseQo+PiBwdXQgaXQgaW4gYmFua2VkX3Nwc3JbMF0uCj4+IAo+ PiBTaWduZWQtb2ZmLWJ5OiBQZXRlciBNYXlkZWxsIDxwZXRlci5tYXlkZWxsQGxpbmFyby5vcmc+ Cj4KPiBSZXZpZXdlZC1ieTogQ2hyaXN0b2ZmZXIgRGFsbCA8Y2hyaXN0b2ZmZXIuZGFsbEBsaW5h cm8ub3JnPgo+Cj4KPiBBbGV4LCB3aWxsIHlvdSByZXNwaW4gdGhlIFNQU1IgcGF0Y2ggYmFzZWQg b24gdGhpcyBvbmUgdGhlbj8gIFlvdSBjYW4KPiBjaGFuZ2UgdGhlIGF1dGhvcnNoaXAgb24gdGhl IFNQU1IgcGF0Y2ggdG8geW91cnNlbGYgaWYgeW91IHByZWZlci4KClllYWggSSdsbCByZS1zcGlu IHRoZSBzZXJpZXMgaG9wZWZ1bGx5IGJ5IHRoZSBlbmQgb2YgdGhpcyB3ZWVrIG9yIGVhcmx5IG5l eHQuCgo+Cj4gVGhhbmtzLAo+IC1DaHJpc3RvZmZlcgoKLS0gCkFsZXggQmVubsOpZQpfX19fX19f X19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fXwprdm1hcm0gbWFpbGluZyBs aXN0Cmt2bWFybUBsaXN0cy5jcy5jb2x1bWJpYS5lZHUKaHR0cHM6Ly9saXN0cy5jcy5jb2x1bWJp YS5lZHUvbWFpbG1hbi9saXN0aW5mby9rdm1hcm0K From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([2001:4830:134:3::10]:45210) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1YYEUO-0004I1-TN for qemu-devel@nongnu.org; Wed, 18 Mar 2015 09:58:29 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1YYEUI-0000NJ-5f for qemu-devel@nongnu.org; Wed, 18 Mar 2015 09:58:28 -0400 Received: from static.88-198-71-155.clients.your-server.de ([88.198.71.155]:53679 helo=socrates.bennee.com) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1YYEUH-0000Mm-VY for qemu-devel@nongnu.org; Wed, 18 Mar 2015 09:58:22 -0400 References: <1426620735-2454-1-git-send-email-peter.maydell@linaro.org> <20150317193816.GB23225@cbox> From: Alex =?utf-8?Q?Benn=C3=A9e?= In-reply-to: <20150317193816.GB23225@cbox> Date: Wed, 18 Mar 2015 13:58:40 +0000 Message-ID: <87twxis8z3.fsf@linaro.org> MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 8bit Subject: Re: [Qemu-devel] [PATCH v2] target-arm: Store SPSR_EL1 state in banked_spsr[1] (SPSR_svc) List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: Christoffer Dall Cc: Peter Maydell , Greg Bellows , kvmarm@lists.cs.columbia.edu, qemu-devel@nongnu.org, patches@linaro.org Christoffer Dall writes: > On Tue, Mar 17, 2015 at 07:32:15PM +0000, Peter Maydell wrote: >> The AArch64 SPSR_EL1 register is architecturally mandated to >> be mapped to the AArch32 SPSR_svc register. This means its >> state should live in QEMU's env->banked_spsr[1] field. >> Correct the various places in the code that incorrectly >> put it in banked_spsr[0]. >> >> Signed-off-by: Peter Maydell > > Reviewed-by: Christoffer Dall > > > Alex, will you respin the SPSR patch based on this one then? You can > change the authorship on the SPSR patch to yourself if you prefer. Yeah I'll re-spin the series hopefully by the end of this week or early next. > > Thanks, > -Christoffer -- Alex Bennée