From: robert.jarzmik@free.fr (Robert Jarzmik)
To: linux-arm-kernel@lists.infradead.org
Subject: [PATCH] net: smc91x: improve neponset hack
Date: Fri, 20 Feb 2015 21:00:32 +0100 [thread overview]
Message-ID: <87twyg73q7.fsf@free.fr> (raw)
In-Reply-To: <5754481.gFE9BvLjh0@wuerfel> (Arnd Bergmann's message of "Fri, 20 Feb 2015 16:47:06 +0100")
Arnd Bergmann <arnd@arndb.de> writes:
> On Thursday 19 February 2015 00:35:49 Russell King - ARM Linux wrote:
>> On Wed, Feb 18, 2015 at 08:47:30PM +0100, Arnd Bergmann wrote:
>> > The smc91x driver tries to support multiple platforms at compile
>> > time, but they are mutually exclusive at runtime, and not clearly
>> > defined.
>>
>> I'd prefer to rework this to fix that properly. From what I remember,
>> the whole SA11x0 stuff in this driver was a mess.
>
> I guess that's reasonable. I've looked through the driver and it seems we
> did most of the multiplatform work but left a few things alone that should
> have been converted a long time ago.
>
> Can you check if the approach below makes sense to you?
>
> I've verified that each machine that defines an smc91x device now sets
> the correct platform data, irq flags and access width, which should be
> enough to collapse all the CONFIG_ARM cases into one.
>
> Signed-off-by: Arnd Bergmann <arnd@arndb.de>
When you're both satisfied with the smc91x patch, I can offer to test it across
the pxa boards (lubbock, zylonite, and maybe mainstone). As I'm actively using
the first 2, I'm interested in them being as functional as now :)
Cheers.
--
Robert
WARNING: multiple messages have this Message-ID (diff)
From: Robert Jarzmik <robert.jarzmik@free.fr>
To: Arnd Bergmann <arnd@arndb.de>,
Russell King - ARM Linux <linux@arm.linux.org.uk>
Cc: linux-arm-kernel@lists.infradead.org,
Dmitry Eremin-Solenikov <dbaryshkov@gmail.com>,
netdev@vger.kernel.org, Linus Walleij <linus.walleij@linaro.org>,
linux-kernel@vger.kernel.org, davem@davemloft.net
Subject: Re: [PATCH] net: smc91x: improve neponset hack
Date: Fri, 20 Feb 2015 21:00:32 +0100 [thread overview]
Message-ID: <87twyg73q7.fsf@free.fr> (raw)
In-Reply-To: <5754481.gFE9BvLjh0@wuerfel> (Arnd Bergmann's message of "Fri, 20 Feb 2015 16:47:06 +0100")
Arnd Bergmann <arnd@arndb.de> writes:
> On Thursday 19 February 2015 00:35:49 Russell King - ARM Linux wrote:
>> On Wed, Feb 18, 2015 at 08:47:30PM +0100, Arnd Bergmann wrote:
>> > The smc91x driver tries to support multiple platforms at compile
>> > time, but they are mutually exclusive at runtime, and not clearly
>> > defined.
>>
>> I'd prefer to rework this to fix that properly. From what I remember,
>> the whole SA11x0 stuff in this driver was a mess.
>
> I guess that's reasonable. I've looked through the driver and it seems we
> did most of the multiplatform work but left a few things alone that should
> have been converted a long time ago.
>
> Can you check if the approach below makes sense to you?
>
> I've verified that each machine that defines an smc91x device now sets
> the correct platform data, irq flags and access width, which should be
> enough to collapse all the CONFIG_ARM cases into one.
>
> Signed-off-by: Arnd Bergmann <arnd@arndb.de>
When you're both satisfied with the smc91x patch, I can offer to test it across
the pxa boards (lubbock, zylonite, and maybe mainstone). As I'm actively using
the first 2, I'm interested in them being as functional as now :)
Cheers.
--
Robert
next prev parent reply other threads:[~2015-02-20 20:00 UTC|newest]
Thread overview: 18+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-02-18 19:47 [PATCH] net: smc91x: improve neponset hack Arnd Bergmann
2015-02-18 19:47 ` Arnd Bergmann
2015-02-19 0:35 ` Russell King - ARM Linux
2015-02-19 0:35 ` Russell King - ARM Linux
2015-02-20 15:47 ` Arnd Bergmann
2015-02-20 15:47 ` Arnd Bergmann
2015-02-20 20:00 ` Robert Jarzmik [this message]
2015-02-20 20:00 ` Robert Jarzmik
2015-02-20 21:23 ` David Miller
2015-02-20 21:23 ` David Miller
2015-03-09 12:20 ` Russell King - ARM Linux
2015-03-09 12:20 ` Russell King - ARM Linux
2015-03-09 12:34 ` Russell King - ARM Linux
2015-03-09 12:34 ` Russell King - ARM Linux
2015-03-09 17:14 ` David Miller
2015-03-09 17:14 ` David Miller
2015-02-20 21:23 ` David Miller
2015-02-20 21:23 ` David Miller
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=87twyg73q7.fsf@free.fr \
--to=robert.jarzmik@free.fr \
--cc=linux-arm-kernel@lists.infradead.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.