From mboxrd@z Thu Jan  1 00:00:00 1970
Received: from eggs.gnu.org ([2001:4830:134:3::10]:40653)
	by lists.gnu.org with esmtp (Exim 4.71)
	(envelope-from <alex.bennee@linaro.org>) id 1YBmsw-0000m2-U3
	for qemu-devel@nongnu.org; Thu, 15 Jan 2015 11:03:03 -0500
Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71)
	(envelope-from <alex.bennee@linaro.org>) id 1YBmss-0005Xz-2x
	for qemu-devel@nongnu.org; Thu, 15 Jan 2015 11:03:02 -0500
Received: from static.88-198-71-155.clients.your-server.de
	([88.198.71.155]:37899 helo=socrates.bennee.com)
	by eggs.gnu.org with esmtp (Exim 4.71)
	(envelope-from <alex.bennee@linaro.org>) id 1YBmsr-0005Xv-Tc
	for qemu-devel@nongnu.org; Thu, 15 Jan 2015 11:02:58 -0500
References: <1421334118-3287-1-git-send-email-peter.maydell@linaro.org>
	<1421334118-3287-8-git-send-email-peter.maydell@linaro.org>
From: Alex =?utf-8?Q?Benn=C3=A9e?= <alex.bennee@linaro.org>
In-reply-to: <1421334118-3287-8-git-send-email-peter.maydell@linaro.org>
Date: Thu, 15 Jan 2015 16:03:03 +0000
Message-ID: <87twzs116w.fsf@linaro.org>
MIME-Version: 1.0
Content-Type: text/plain; charset=utf-8
Content-Transfer-Encoding: 8bit
Subject: Re: [Qemu-devel] [PATCH 07/15] linux-user/main.c (m68k): Use
	get_user_u16 rather than lduw in cpu_loop
List-Id: <qemu-devel.nongnu.org>
List-Unsubscribe: <https://lists.nongnu.org/mailman/options/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=unsubscribe>
List-Archive: <http://lists.nongnu.org/archive/html/qemu-devel>
List-Post: <mailto:qemu-devel@nongnu.org>
List-Help: <mailto:qemu-devel-request@nongnu.org?subject=help>
List-Subscribe: <https://lists.nongnu.org/mailman/listinfo/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=subscribe>
To: Peter Maydell <peter.maydell@linaro.org>
Cc: Paolo Bonzini <pbonzini@redhat.com>, Riku Voipio <riku.voipio@iki.fi>, qemu-devel@nongnu.org, patches@linaro.org, Richard Henderson <rth@twiddle.net>


Peter Maydell <peter.maydell@linaro.org> writes:

> In the m68k cpu_loop() use get_user_u16 to read the immediate for
> the simcall rahter than lduw, to bring it into line with how other
> archs do it and to remove another user of the ldl family of functions.
>
> Signed-off-by: Peter Maydell <peter.maydell@linaro.org>

After getting lost tracing the many macro definitions from lduw ;-)

Reviewed-by: Alex Bennée <alex.bennee@linaro.org>

> ---
>  linux-user/main.c | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/linux-user/main.c b/linux-user/main.c
> index 67b0231..65b5a36 100644
> --- a/linux-user/main.c
> +++ b/linux-user/main.c
> @@ -2972,7 +2972,7 @@ void cpu_loop(CPUM68KState *env)
>              {
>                  if (ts->sim_syscalls) {
>                      uint16_t nr;
> -                    nr = lduw(env->pc + 2);
> +                    get_user_u16(nr, env->pc + 2);
>                      env->pc += 4;
>                      do_m68k_simcall(env, nr);
>                  } else {

-- 
Alex Bennée