From mboxrd@z Thu Jan 1 00:00:00 1970 From: Jani Nikula Date: Wed, 29 Oct 2014 07:54:36 +0000 Subject: Re: [PATCH] drivers: depend on instead of select BACKLIGHT_CLASS_DEVICE and ACPI_VIDEO Message-Id: <87tx2njooz.fsf@intel.com> List-Id: References: <1413580403-16225-1-git-send-email-jani.nikula@intel.com> <54476492.6090105@ti.com> <87a94hu3j0.fsf@intel.com> <544E44E9.4040208@ti.com> <544FFC91.9040104@infradead.org> <1414551853.7417.1.camel@concordia> In-Reply-To: <1414551853.7417.1.camel@concordia> MIME-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit To: Michael Ellerman , Randy Dunlap Cc: linux-fbdev@vger.kernel.org, linux-usb@vger.kernel.org, Daniel Drake , Jens Frederich , Greg Kroah-Hartman , Jon Nettleton , Jingoo Han , linux-kernel@vger.kernel.org, dri-devel@lists.freedesktop.org, platform-driver-x86@vger.kernel.org, Bryan Wu , linuxppc-dev@lists.ozlabs.org, Tomi Valkeinen , Laurent Pinchart , Daniel Vetter , Darren Hart , Lee Jones , Jean-Christophe Plagniol-Villard On Wed, 29 Oct 2014, Michael Ellerman wrote: > On Tue, 2014-10-28 at 13:29 -0700, Randy Dunlap wrote: >> On 10/27/14 06:13, Tomi Valkeinen wrote: >> > I also think the 'depends on BACKLIGHT_CLASS_DEVICE || >> > BACKLIGHT_CLASS_DEVICE=n' pattern is quite... interesting (i.e. sounds >> > like a hack to me =). >> >> It does exactly what is needed and it is used in many places in kernel >> Kconfig files. > > Is there any reason you can't do: > > depends on BACKLIGHT_CLASS_DEVICE != m That's not the same thing. The FOO || FOO=n allows for all options, but forbids it being a module when the option depending on it is built-in. Obviously something that's built-in can't depend on something built as a module. BR, Jani. -- Jani Nikula, Intel Open Source Technology Center From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mga11.intel.com (mga11.intel.com [192.55.52.93]) by lists.ozlabs.org (Postfix) with ESMTP id E92D71A0063 for ; Wed, 29 Oct 2014 18:55:02 +1100 (AEDT) From: Jani Nikula To: Michael Ellerman , Randy Dunlap Subject: Re: [PATCH] drivers: depend on instead of select BACKLIGHT_CLASS_DEVICE and ACPI_VIDEO In-Reply-To: <1414551853.7417.1.camel@concordia> References: <1413580403-16225-1-git-send-email-jani.nikula@intel.com> <54476492.6090105@ti.com> <87a94hu3j0.fsf@intel.com> <544E44E9.4040208@ti.com> <544FFC91.9040104@infradead.org> <1414551853.7417.1.camel@concordia> Date: Wed, 29 Oct 2014 09:54:36 +0200 Message-ID: <87tx2njooz.fsf@intel.com> MIME-Version: 1.0 Content-Type: text/plain Cc: linux-fbdev@vger.kernel.org, linux-usb@vger.kernel.org, Daniel Drake , Jens Frederich , David Airlie , Greg Kroah-Hartman , Jon Nettleton , Jingoo Han , linux-kernel@vger.kernel.org, dri-devel@lists.freedesktop.org, platform-driver-x86@vger.kernel.org, Bryan Wu , linuxppc-dev@lists.ozlabs.org, Tomi Valkeinen , Laurent Pinchart , Daniel Vetter , Darren Hart , Lee Jones , Jean-Christophe Plagniol-Villard List-Id: Linux on PowerPC Developers Mail List List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , On Wed, 29 Oct 2014, Michael Ellerman wrote: > On Tue, 2014-10-28 at 13:29 -0700, Randy Dunlap wrote: >> On 10/27/14 06:13, Tomi Valkeinen wrote: >> > I also think the 'depends on BACKLIGHT_CLASS_DEVICE || >> > BACKLIGHT_CLASS_DEVICE=n' pattern is quite... interesting (i.e. sounds >> > like a hack to me =). >> >> It does exactly what is needed and it is used in many places in kernel >> Kconfig files. > > Is there any reason you can't do: > > depends on BACKLIGHT_CLASS_DEVICE != m That's not the same thing. The FOO || FOO=n allows for all options, but forbids it being a module when the option depending on it is built-in. Obviously something that's built-in can't depend on something built as a module. BR, Jani. -- Jani Nikula, Intel Open Source Technology Center From mboxrd@z Thu Jan 1 00:00:00 1970 From: Jani Nikula Subject: Re: [PATCH] drivers: depend on instead of select BACKLIGHT_CLASS_DEVICE and ACPI_VIDEO Date: Wed, 29 Oct 2014 09:54:36 +0200 Message-ID: <87tx2njooz.fsf@intel.com> References: <1413580403-16225-1-git-send-email-jani.nikula@intel.com> <54476492.6090105@ti.com> <87a94hu3j0.fsf@intel.com> <544E44E9.4040208@ti.com> <544FFC91.9040104@infradead.org> <1414551853.7417.1.camel@concordia> Mime-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: base64 Return-path: In-Reply-To: <1414551853.7417.1.camel@concordia> List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dri-devel-bounces@lists.freedesktop.org Sender: "dri-devel" To: Michael Ellerman , Randy Dunlap Cc: linux-fbdev@vger.kernel.org, linux-usb@vger.kernel.org, Daniel Drake , Jens Frederich , Greg Kroah-Hartman , Jon Nettleton , Jingoo Han , linux-kernel@vger.kernel.org, dri-devel@lists.freedesktop.org, platform-driver-x86@vger.kernel.org, Bryan Wu , linuxppc-dev@lists.ozlabs.org, Tomi Valkeinen , Laurent Pinchart , Daniel Vetter , Darren Hart , Lee Jones , Jean-Christophe Plagniol-Villard List-Id: platform-driver-x86.vger.kernel.org T24gV2VkLCAyOSBPY3QgMjAxNCwgTWljaGFlbCBFbGxlcm1hbiA8bXBlQGVsbGVybWFuLmlkLmF1 PiB3cm90ZToKPiBPbiBUdWUsIDIwMTQtMTAtMjggYXQgMTM6MjkgLTA3MDAsIFJhbmR5IER1bmxh cCB3cm90ZToKPj4gT24gMTAvMjcvMTQgMDY6MTMsIFRvbWkgVmFsa2VpbmVuIHdyb3RlOgo+PiA+ IEkgYWxzbyB0aGluayB0aGUgJ2RlcGVuZHMgb24gQkFDS0xJR0hUX0NMQVNTX0RFVklDRSB8fAo+ PiA+IEJBQ0tMSUdIVF9DTEFTU19ERVZJQ0U9bicgcGF0dGVybiBpcyBxdWl0ZS4uLiBpbnRlcmVz dGluZyAoaS5lLiBzb3VuZHMKPj4gPiBsaWtlIGEgaGFjayB0byBtZSA9KS4KPj4gCj4+IEl0IGRv ZXMgZXhhY3RseSB3aGF0IGlzIG5lZWRlZCBhbmQgaXQgaXMgdXNlZCBpbiBtYW55IHBsYWNlcyBp biBrZXJuZWwKPj4gS2NvbmZpZyBmaWxlcy4KPgo+IElzIHRoZXJlIGFueSByZWFzb24geW91IGNh bid0IGRvOgo+Cj4gICBkZXBlbmRzIG9uIEJBQ0tMSUdIVF9DTEFTU19ERVZJQ0UgIT0gbQoKVGhh dCdzIG5vdCB0aGUgc2FtZSB0aGluZy4gVGhlIEZPTyB8fCBGT089biBhbGxvd3MgZm9yIGFsbCBv cHRpb25zLCBidXQKZm9yYmlkcyBpdCBiZWluZyBhIG1vZHVsZSB3aGVuIHRoZSBvcHRpb24gZGVw ZW5kaW5nIG9uIGl0IGlzCmJ1aWx0LWluLiBPYnZpb3VzbHkgc29tZXRoaW5nIHRoYXQncyBidWls dC1pbiBjYW4ndCBkZXBlbmQgb24gc29tZXRoaW5nCmJ1aWx0IGFzIGEgbW9kdWxlLgoKQlIsCkph bmkuCgoKLS0gCkphbmkgTmlrdWxhLCBJbnRlbCBPcGVuIFNvdXJjZSBUZWNobm9sb2d5IENlbnRl cgpfX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fXwpkcmktZGV2 ZWwgbWFpbGluZyBsaXN0CmRyaS1kZXZlbEBsaXN0cy5mcmVlZGVza3RvcC5vcmcKaHR0cDovL2xp c3RzLmZyZWVkZXNrdG9wLm9yZy9tYWlsbWFuL2xpc3RpbmZvL2RyaS1kZXZlbAo= From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1755823AbaJ2HzE (ORCPT ); Wed, 29 Oct 2014 03:55:04 -0400 Received: from mga11.intel.com ([192.55.52.93]:58994 "EHLO mga11.intel.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1752843AbaJ2HzB (ORCPT ); Wed, 29 Oct 2014 03:55:01 -0400 X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.04,808,1406617200"; d="scan'208";a="622614910" From: Jani Nikula To: Michael Ellerman , Randy Dunlap Cc: Tomi Valkeinen , Jean-Christophe Plagniol-Villard , linux-fbdev@vger.kernel.org, Jingoo Han , Daniel Drake , Jens Frederich , David Airlie , Greg Kroah-Hartman , Jon Nettleton , linux-usb@vger.kernel.org, linux-kernel@vger.kernel.org, dri-devel@lists.freedesktop.org, platform-driver-x86@vger.kernel.org, Lee Jones , Laurent Pinchart , Darren Hart , Daniel Vetter , Bryan Wu , linuxppc-dev@lists.ozlabs.org Subject: Re: [PATCH] drivers: depend on instead of select BACKLIGHT_CLASS_DEVICE and ACPI_VIDEO In-Reply-To: <1414551853.7417.1.camel@concordia> Organization: Intel Finland Oy - BIC 0357606-4 - Westendinkatu 7, 02160 Espoo References: <1413580403-16225-1-git-send-email-jani.nikula@intel.com> <54476492.6090105@ti.com> <87a94hu3j0.fsf@intel.com> <544E44E9.4040208@ti.com> <544FFC91.9040104@infradead.org> <1414551853.7417.1.camel@concordia> User-Agent: Notmuch/0.18.1+133~g83c61fa (http://notmuchmail.org) Emacs/24.3.1 (x86_64-pc-linux-gnu) Date: Wed, 29 Oct 2014 09:54:36 +0200 Message-ID: <87tx2njooz.fsf@intel.com> MIME-Version: 1.0 Content-Type: text/plain Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Wed, 29 Oct 2014, Michael Ellerman wrote: > On Tue, 2014-10-28 at 13:29 -0700, Randy Dunlap wrote: >> On 10/27/14 06:13, Tomi Valkeinen wrote: >> > I also think the 'depends on BACKLIGHT_CLASS_DEVICE || >> > BACKLIGHT_CLASS_DEVICE=n' pattern is quite... interesting (i.e. sounds >> > like a hack to me =). >> >> It does exactly what is needed and it is used in many places in kernel >> Kconfig files. > > Is there any reason you can't do: > > depends on BACKLIGHT_CLASS_DEVICE != m That's not the same thing. The FOO || FOO=n allows for all options, but forbids it being a module when the option depending on it is built-in. Obviously something that's built-in can't depend on something built as a module. BR, Jani. -- Jani Nikula, Intel Open Source Technology Center