All of lore.kernel.org
 help / color / mirror / Atom feed
From: Robert Jarzmik <robert.jarzmik@free.fr>
To: Brian Norris <computersforpeace@gmail.com>
Cc: "linux-mtd@lists.infradead.org" <linux-mtd@lists.infradead.org>
Subject: Re: [PATCH] mtd: docg3: fix 'defined but not used' warning
Date: Wed, 22 Oct 2014 21:38:39 +0200	[thread overview]
Message-ID: <87tx2vlwsg.fsf@free.fr> (raw)
In-Reply-To: <CAN8TOE9yDA=v_v-48ZiG=5+Dk_JamxYxd_0jrWGtwQ5QXGrszA@mail.gmail.com> (Brian Norris's message of "Wed, 22 Oct 2014 10:33:28 -0700")

Brian Norris <computersforpeace@gmail.com> writes:

> On Wed, Oct 22, 2014 at 10:23 AM, Brian Norris
> <computersforpeace@gmail.com> wrote:
>>    drivers/mtd/devices/docg3.c:2122:28: warning: 'docg3_dt_ids' defined but not used [-Wunused-variable]
>>     static struct of_device_id docg3_dt_ids[] = {
>
> I suppose I should add that this only happens when CONFIG_OF=n. I'll
> add this to the commit message if/when I apply this.

Thanks Brian, I had forgotten the non device-tree case, and overviewed the
warning. Your change is the way to go.

Cheers.

--
Robert

  reply	other threads:[~2014-10-22 19:39 UTC|newest]

Thread overview: 4+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2014-10-22 17:23 [PATCH] mtd: docg3: fix 'defined but not used' warning Brian Norris
2014-10-22 17:33 ` Brian Norris
2014-10-22 19:38   ` Robert Jarzmik [this message]
2014-10-22 21:02     ` Brian Norris

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=87tx2vlwsg.fsf@free.fr \
    --to=robert.jarzmik@free.fr \
    --cc=computersforpeace@gmail.com \
    --cc=linux-mtd@lists.infradead.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.