From mboxrd@z Thu Jan  1 00:00:00 1970
Received: from eggs.gnu.org ([2001:4830:134:3::10]:51881)
	by lists.gnu.org with esmtp (Exim 4.71)
	(envelope-from <armbru@redhat.com>) id 1XZgeP-0007SJ-S0
	for qemu-devel@nongnu.org; Thu, 02 Oct 2014 09:42:39 -0400
Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71)
	(envelope-from <armbru@redhat.com>) id 1XZgeJ-00005y-4G
	for qemu-devel@nongnu.org; Thu, 02 Oct 2014 09:42:33 -0400
Received: from mx1.redhat.com ([209.132.183.28]:49339)
	by eggs.gnu.org with esmtp (Exim 4.71)
	(envelope-from <armbru@redhat.com>) id 1XZgeI-00005t-Tq
	for qemu-devel@nongnu.org; Thu, 02 Oct 2014 09:42:27 -0400
From: Markus Armbruster <armbru@redhat.com>
References: <1412078370-3555-1-git-send-email-armbru@redhat.com>
	<20141002131826.GC30564@stefanha-thinkpad.redhat.com>
Date: Thu, 02 Oct 2014 15:42:21 +0200
In-Reply-To: <20141002131826.GC30564@stefanha-thinkpad.redhat.com> (Stefan
	Hajnoczi's message of "Thu, 2 Oct 2014 14:18:26 +0100")
Message-ID: <87tx3md1vm.fsf@blackfin.pond.sub.org>
MIME-Version: 1.0
Content-Type: text/plain
Subject: Re: [Qemu-devel] [PATCH] util: Emancipate id_wellformed() from
	QemuOpts
List-Id: <qemu-devel.nongnu.org>
List-Unsubscribe: <https://lists.nongnu.org/mailman/options/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=unsubscribe>
List-Archive: <http://lists.nongnu.org/archive/html/qemu-devel>
List-Post: <mailto:qemu-devel@nongnu.org>
List-Help: <mailto:qemu-devel-request@nongnu.org?subject=help>
List-Subscribe: <https://lists.nongnu.org/mailman/listinfo/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=subscribe>
To: Stefan Hajnoczi <stefanha@gmail.com>
Cc: kwolf@redhat.com, qemu-devel@nongnu.org, stefanha@redhat.com

Stefan Hajnoczi <stefanha@gmail.com> writes:

> On Tue, Sep 30, 2014 at 01:59:30PM +0200, Markus Armbruster wrote:
>> +bool id_wellformed(const char *id)
>> +{
>> +    int i;
>> +
>> +    if (!qemu_isalpha(id[0])) {
>> +        return 0;
>
> false would be a bit nicer since the other return cases use true/false.

Missed when I changed the value to bool.  Would you be willing to fix
this up on commit?  If not, I'll respin.