From mboxrd@z Thu Jan  1 00:00:00 1970
Received: from eggs.gnu.org ([2001:4830:134:3::10]:53959)
	by lists.gnu.org with esmtp (Exim 4.71)
	(envelope-from <armbru@redhat.com>) id 1XTvQW-0007CU-4b
	for qemu-devel@nongnu.org; Tue, 16 Sep 2014 12:16:30 -0400
Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71)
	(envelope-from <armbru@redhat.com>) id 1XTvQQ-00058p-0a
	for qemu-devel@nongnu.org; Tue, 16 Sep 2014 12:16:24 -0400
Received: from mx1.redhat.com ([209.132.183.28]:30769)
	by eggs.gnu.org with esmtp (Exim 4.71)
	(envelope-from <armbru@redhat.com>) id 1XTvQP-00058O-QR
	for qemu-devel@nongnu.org; Tue, 16 Sep 2014 12:16:17 -0400
From: Markus Armbruster <armbru@redhat.com>
References: <1410507050-8900-1-git-send-email-arei.gonglei@huawei.com>
	<33183CC9F5247A488A2544077AF1902086DD646C@SZXEMA503-MBS.china.huawei.com>
	<1410877007.32607.9.camel@nilsson.home.kraxel.org>
Date: Tue, 16 Sep 2014 18:16:06 +0200
In-Reply-To: <1410877007.32607.9.camel@nilsson.home.kraxel.org> (Gerd
	Hoffmann's message of "Tue, 16 Sep 2014 16:16:47 +0200")
Message-ID: <87tx47a6d5.fsf@blackfin.pond.sub.org>
MIME-Version: 1.0
Content-Type: text/plain
Subject: Re: [Qemu-devel] [PATCH v2 0/2] usb: Don't use qerror_report
List-Id: <qemu-devel.nongnu.org>
List-Unsubscribe: <https://lists.nongnu.org/mailman/options/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=unsubscribe>
List-Archive: <http://lists.nongnu.org/archive/html/qemu-devel>
List-Post: <mailto:qemu-devel@nongnu.org>
List-Help: <mailto:qemu-devel-request@nongnu.org?subject=help>
List-Subscribe: <https://lists.nongnu.org/mailman/listinfo/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=subscribe>
To: Gerd Hoffmann <kraxel@redhat.com>
Cc: "Gonglei (Arei)" <arei.gonglei@huawei.com>, "Huangweidong (C)" <weidong.huang@huawei.com>, "qemu-devel@nongnu.org" <qemu-devel@nongnu.org>

Gerd Hoffmann <kraxel@redhat.com> writes:

>   Hi,
>
>> > Gonglei (2):
>> >   redirect.c: Don't use qerror_report()
>> >   dev-network: Don't use qerror_report_err()
>
>> Hi, Gerd 
>> Would you like to apply this patch series at present? Thanks!
>
> Picked it up now.  Originally dropped due to review comments from paolo,
> but switching all usb over to realize is a bigger project indeed.

Please don't, it degrades QMP errors.  Example:

    { "execute": "device_add", "arguments": { "driver": "usb-redir" } }

Reply before:

    {"error": {"class": "GenericError", "desc": "Parameter 'chardev' is missing"}}

After:

    {"error": {"class": "GenericError", "desc": "Device initialization failed."}}

with "Parameter 'chardev' is missing" barfed to stderr.