From mboxrd@z Thu Jan 1 00:00:00 1970 From: "Aneesh Kumar K.V" Date: Fri, 06 Jun 2014 09:40:49 +0000 Subject: Re: [PATCH 2/4] KVM: PPC: BOOK3S: PR: Doorbell support Message-Id: <87tx7ye69a.fsf@linux.vnet.ibm.com> List-Id: References: <1401970085-14493-1-git-send-email-aneesh.kumar@linux.vnet.ibm.com> <1401970085-14493-3-git-send-email-aneesh.kumar@linux.vnet.ibm.com> <539060B5.9040808@suse.de> In-Reply-To: <539060B5.9040808@suse.de> MIME-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit To: Alexander Graf , benh@kernel.crashing.org, paulus@samba.org Cc: linuxppc-dev@lists.ozlabs.org, kvm@vger.kernel.org, kvm-ppc@vger.kernel.org Alexander Graf writes: > On 05.06.14 14:08, Aneesh Kumar K.V wrote: >> We don't have SMT support yet, hence we should not find a doorbell >> message generated >> >> Signed-off-by: Aneesh Kumar K.V >> --- >> arch/powerpc/kvm/book3s_emulate.c | 18 ++++++++++++++++++ >> 1 file changed, 18 insertions(+) >> >> diff --git a/arch/powerpc/kvm/book3s_emulate.c b/arch/powerpc/kvm/book3s_emulate.c >> index 1bb16a59dcbc..d6c87d085182 100644 >> --- a/arch/powerpc/kvm/book3s_emulate.c >> +++ b/arch/powerpc/kvm/book3s_emulate.c >> @@ -28,7 +28,9 @@ >> #define OP_19_XOP_RFI 50 >> >> #define OP_31_XOP_MFMSR 83 >> +#define OP_31_XOP_MSGSNDP 142 >> #define OP_31_XOP_MTMSR 146 >> +#define OP_31_XOP_MSGCLRP 174 >> #define OP_31_XOP_MTMSRD 178 >> #define OP_31_XOP_MTSR 210 >> #define OP_31_XOP_MTSRIN 242 >> @@ -303,6 +305,22 @@ int kvmppc_core_emulate_op_pr(struct kvm_run *run, struct kvm_vcpu *vcpu, >> >> break; >> } >> + case OP_31_XOP_MSGSNDP: >> + { >> + /* >> + * PR KVM still don't support SMT mode. So we should > > still? > >> + * not see a MSGSNDP/MSGCLRP used with PR KVM >> + */ >> + pr_info("KVM: MSGSNDP used in non SMT case\n"); >> + emulated = EMULATE_FAIL; > > What would happen on an HV guest with only 1 thread that MSGSNDs to > thread 0? Would the guest get an illegal instruction trap, a > self-interrupt or would this be a simple nop? > We do get a self-interrupt. I tried the below tag = mfspr(SPRN_TIR) & 0x7f; ppc_msgsnd(5, 0, tag); And that results in doorbell exception. That implies we will have to have full implementation of doorbell. You can drop patch 2 and 3 from this series. I will rework them. NOTE: This is not an issue for Linux guest, because we don't send ipi to self. But to complete the emulation of msgsndp we will need to emulate it properly. -aneesh From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from e28smtp02.in.ibm.com (e28smtp02.in.ibm.com [122.248.162.2]) (using TLSv1 with cipher DHE-RSA-AES256-SHA (256/256 bits)) (No client certificate requested) by lists.ozlabs.org (Postfix) with ESMTPS id 9F4491A0008 for ; Fri, 6 Jun 2014 19:29:01 +1000 (EST) Received: from /spool/local by e28smtp02.in.ibm.com with IBM ESMTP SMTP Gateway: Authorized Use Only! Violators will be prosecuted for from ; Fri, 6 Jun 2014 14:58:54 +0530 Received: from d28relay05.in.ibm.com (d28relay05.in.ibm.com [9.184.220.62]) by d28dlp03.in.ibm.com (Postfix) with ESMTP id A31FE1258053 for ; Fri, 6 Jun 2014 14:58:09 +0530 (IST) Received: from d28av02.in.ibm.com (d28av02.in.ibm.com [9.184.220.64]) by d28relay05.in.ibm.com (8.13.8/8.13.8/NCO v10.0) with ESMTP id s569T3j356688740 for ; Fri, 6 Jun 2014 14:59:03 +0530 Received: from d28av02.in.ibm.com (localhost [127.0.0.1]) by d28av02.in.ibm.com (8.14.4/8.14.4/NCO v10.0 AVout) with ESMTP id s569Sokj026632 for ; Fri, 6 Jun 2014 14:58:50 +0530 From: "Aneesh Kumar K.V" To: Alexander Graf , benh@kernel.crashing.org, paulus@samba.org Subject: Re: [PATCH 2/4] KVM: PPC: BOOK3S: PR: Doorbell support In-Reply-To: <539060B5.9040808@suse.de> References: <1401970085-14493-1-git-send-email-aneesh.kumar@linux.vnet.ibm.com> <1401970085-14493-3-git-send-email-aneesh.kumar@linux.vnet.ibm.com> <539060B5.9040808@suse.de> Date: Fri, 06 Jun 2014 14:58:49 +0530 Message-ID: <87tx7ye69a.fsf@linux.vnet.ibm.com> MIME-Version: 1.0 Content-Type: text/plain Cc: linuxppc-dev@lists.ozlabs.org, kvm@vger.kernel.org, kvm-ppc@vger.kernel.org List-Id: Linux on PowerPC Developers Mail List List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Alexander Graf writes: > On 05.06.14 14:08, Aneesh Kumar K.V wrote: >> We don't have SMT support yet, hence we should not find a doorbell >> message generated >> >> Signed-off-by: Aneesh Kumar K.V >> --- >> arch/powerpc/kvm/book3s_emulate.c | 18 ++++++++++++++++++ >> 1 file changed, 18 insertions(+) >> >> diff --git a/arch/powerpc/kvm/book3s_emulate.c b/arch/powerpc/kvm/book3s_emulate.c >> index 1bb16a59dcbc..d6c87d085182 100644 >> --- a/arch/powerpc/kvm/book3s_emulate.c >> +++ b/arch/powerpc/kvm/book3s_emulate.c >> @@ -28,7 +28,9 @@ >> #define OP_19_XOP_RFI 50 >> >> #define OP_31_XOP_MFMSR 83 >> +#define OP_31_XOP_MSGSNDP 142 >> #define OP_31_XOP_MTMSR 146 >> +#define OP_31_XOP_MSGCLRP 174 >> #define OP_31_XOP_MTMSRD 178 >> #define OP_31_XOP_MTSR 210 >> #define OP_31_XOP_MTSRIN 242 >> @@ -303,6 +305,22 @@ int kvmppc_core_emulate_op_pr(struct kvm_run *run, struct kvm_vcpu *vcpu, >> >> break; >> } >> + case OP_31_XOP_MSGSNDP: >> + { >> + /* >> + * PR KVM still don't support SMT mode. So we should > > still? > >> + * not see a MSGSNDP/MSGCLRP used with PR KVM >> + */ >> + pr_info("KVM: MSGSNDP used in non SMT case\n"); >> + emulated = EMULATE_FAIL; > > What would happen on an HV guest with only 1 thread that MSGSNDs to > thread 0? Would the guest get an illegal instruction trap, a > self-interrupt or would this be a simple nop? > We do get a self-interrupt. I tried the below tag = mfspr(SPRN_TIR) & 0x7f; ppc_msgsnd(5, 0, tag); And that results in doorbell exception. That implies we will have to have full implementation of doorbell. You can drop patch 2 and 3 from this series. I will rework them. NOTE: This is not an issue for Linux guest, because we don't send ipi to self. But to complete the emulation of msgsndp we will need to emulate it properly. -aneesh From mboxrd@z Thu Jan 1 00:00:00 1970 From: "Aneesh Kumar K.V" Subject: Re: [PATCH 2/4] KVM: PPC: BOOK3S: PR: Doorbell support Date: Fri, 06 Jun 2014 14:58:49 +0530 Message-ID: <87tx7ye69a.fsf@linux.vnet.ibm.com> References: <1401970085-14493-1-git-send-email-aneesh.kumar@linux.vnet.ibm.com> <1401970085-14493-3-git-send-email-aneesh.kumar@linux.vnet.ibm.com> <539060B5.9040808@suse.de> Mime-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: base64 Cc: linuxppc-dev@lists.ozlabs.org, kvm@vger.kernel.org, kvm-ppc@vger.kernel.org To: Alexander Graf , benh@kernel.crashing.org, paulus@samba.org Return-path: In-Reply-To: <539060B5.9040808@suse.de> List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: linuxppc-dev-bounces+glppe-linuxppc-embedded-2=m.gmane.org@lists.ozlabs.org Sender: "Linuxppc-dev" List-Id: kvm.vger.kernel.org QWxleGFuZGVyIEdyYWYgPGFncmFmQHN1c2UuZGU+IHdyaXRlczoKCj4gT24gMDUuMDYuMTQgMTQ6 MDgsIEFuZWVzaCBLdW1hciBLLlYgd3JvdGU6Cj4+IFdlIGRvbid0IGhhdmUgU01UIHN1cHBvcnQg eWV0LCBoZW5jZSB3ZSBzaG91bGQgbm90IGZpbmQgYSBkb29yYmVsbAo+PiBtZXNzYWdlIGdlbmVy YXRlZAo+Pgo+PiBTaWduZWQtb2ZmLWJ5OiBBbmVlc2ggS3VtYXIgSy5WIDxhbmVlc2gua3VtYXJA bGludXgudm5ldC5pYm0uY29tPgo+PiAtLS0KPj4gICBhcmNoL3Bvd2VycGMva3ZtL2Jvb2szc19l bXVsYXRlLmMgfCAxOCArKysrKysrKysrKysrKysrKysKPj4gICAxIGZpbGUgY2hhbmdlZCwgMTgg aW5zZXJ0aW9ucygrKQo+Pgo+PiBkaWZmIC0tZ2l0IGEvYXJjaC9wb3dlcnBjL2t2bS9ib29rM3Nf ZW11bGF0ZS5jIGIvYXJjaC9wb3dlcnBjL2t2bS9ib29rM3NfZW11bGF0ZS5jCj4+IGluZGV4IDFi YjE2YTU5ZGNiYy4uZDZjODdkMDg1MTgyIDEwMDY0NAo+PiAtLS0gYS9hcmNoL3Bvd2VycGMva3Zt L2Jvb2szc19lbXVsYXRlLmMKPj4gKysrIGIvYXJjaC9wb3dlcnBjL2t2bS9ib29rM3NfZW11bGF0 ZS5jCj4+IEBAIC0yOCw3ICsyOCw5IEBACj4+ICAgI2RlZmluZSBPUF8xOV9YT1BfUkZJCQk1MAo+ PiAgIAo+PiAgICNkZWZpbmUgT1BfMzFfWE9QX01GTVNSCQk4Mwo+PiArI2RlZmluZSBPUF8zMV9Y T1BfTVNHU05EUAkxNDIKPj4gICAjZGVmaW5lIE9QXzMxX1hPUF9NVE1TUgkJMTQ2Cj4+ICsjZGVm aW5lIE9QXzMxX1hPUF9NU0dDTFJQCTE3NAo+PiAgICNkZWZpbmUgT1BfMzFfWE9QX01UTVNSRAkx NzgKPj4gICAjZGVmaW5lIE9QXzMxX1hPUF9NVFNSCQkyMTAKPj4gICAjZGVmaW5lIE9QXzMxX1hP UF9NVFNSSU4JMjQyCj4+IEBAIC0zMDMsNiArMzA1LDIyIEBAIGludCBrdm1wcGNfY29yZV9lbXVs YXRlX29wX3ByKHN0cnVjdCBrdm1fcnVuICpydW4sIHN0cnVjdCBrdm1fdmNwdSAqdmNwdSwKPj4g ICAKPj4gICAJCQlicmVhazsKPj4gICAJCX0KPj4gKwkJY2FzZSBPUF8zMV9YT1BfTVNHU05EUDoK Pj4gKwkJewo+PiArCQkJLyoKPj4gKwkJCSAqIFBSIEtWTSBzdGlsbCBkb24ndCBzdXBwb3J0IFNN VCBtb2RlLiBTbyB3ZSBzaG91bGQKPgo+IHN0aWxsPwo+Cj4+ICsJCQkgKiBub3Qgc2VlIGEgTVNH U05EUC9NU0dDTFJQIHVzZWQgd2l0aCBQUiBLVk0KPj4gKwkJCSAqLwo+PiArCQkJcHJfaW5mbygi S1ZNOiBNU0dTTkRQIHVzZWQgaW4gbm9uIFNNVCBjYXNlXG4iKTsKPj4gKwkJCWVtdWxhdGVkID0g RU1VTEFURV9GQUlMOwo+Cj4gV2hhdCB3b3VsZCBoYXBwZW4gb24gYW4gSFYgZ3Vlc3Qgd2l0aCBv bmx5IDEgdGhyZWFkIHRoYXQgTVNHU05EcyB0byAKPiB0aHJlYWQgMD8gV291bGQgdGhlIGd1ZXN0 IGdldCBhbiBpbGxlZ2FsIGluc3RydWN0aW9uIHRyYXAsIGEgCj4gc2VsZi1pbnRlcnJ1cHQgb3Ig d291bGQgdGhpcyBiZSBhIHNpbXBsZSBub3A/Cj4KCldlIGRvIGdldCBhIHNlbGYtaW50ZXJydXB0 LiBJIHRyaWVkIHRoZSBiZWxvdwoKdGFnID0gbWZzcHIoU1BSTl9USVIpICYgMHg3ZjsKcHBjX21z Z3NuZCg1LCAwLCB0YWcpOwoKQW5kIHRoYXQgcmVzdWx0cyBpbiBkb29yYmVsbCBleGNlcHRpb24u IFRoYXQgaW1wbGllcyB3ZSB3aWxsIGhhdmUgdG8KaGF2ZSBmdWxsIGltcGxlbWVudGF0aW9uIG9m IGRvb3JiZWxsLiBZb3UgY2FuIGRyb3AgcGF0Y2ggMiBhbmQgMyBmcm9tCnRoaXMgc2VyaWVzLiBJ IHdpbGwgcmV3b3JrIHRoZW0uCgpOT1RFOiBUaGlzIGlzIG5vdCBhbiBpc3N1ZSBmb3IgTGludXgg Z3Vlc3QsIGJlY2F1c2Ugd2UgZG9uJ3Qgc2VuZCBpcGkKdG8gc2VsZi4gQnV0IHRvIGNvbXBsZXRl IHRoZSBlbXVsYXRpb24gb2YgbXNnc25kcCB3ZSB3aWxsIG5lZWQgdG8KZW11bGF0ZSBpdCBwcm9w ZXJseS4KCi1hbmVlc2gKCl9fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19f X19fX19fCkxpbnV4cHBjLWRldiBtYWlsaW5nIGxpc3QKTGludXhwcGMtZGV2QGxpc3RzLm96bGFi cy5vcmcKaHR0cHM6Ly9saXN0cy5vemxhYnMub3JnL2xpc3RpbmZvL2xpbnV4cHBjLWRldg==