From mboxrd@z Thu Jan 1 00:00:00 1970 From: "Aneesh Kumar K.V" Date: Mon, 05 May 2014 14:38:22 +0000 Subject: Re: [PATCH V4] POWERPC: BOOK3S: KVM: Use the saved dar value and generic make_dsisr Message-Id: <87tx949u9d.fsf@linux.vnet.ibm.com> List-Id: References: <1399224075-18041-1-git-send-email-aneesh.kumar@linux.vnet.ibm.com> <536773C2.1070502@suse.de> In-Reply-To: <536773C2.1070502@suse.de> MIME-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit To: Alexander Graf Cc: paulus@samba.org, linuxppc-dev@lists.ozlabs.org, kvm-ppc@vger.kernel.org, kvm@vger.kernel.org Alexander Graf writes: > On 05/04/2014 07:21 PM, Aneesh Kumar K.V wrote: >> Although it's optional IBM POWER cpus always had DAR value set on >> alignment interrupt. So don't try to compute these values. >> >> Signed-off-by: Aneesh Kumar K.V >> --- >> Changes from V3: >> * Use make_dsisr instead of checking feature flag to decide whether to use >> saved dsisr or not >> .... >> ulong kvmppc_alignment_dar(struct kvm_vcpu *vcpu, unsigned int inst) >> { >> +#ifdef CONFIG_PPC_BOOK3S_64 >> + return vcpu->arch.fault_dar; > > How about PA6T and G5s? > > Paul mentioned that BOOK3S always had DAR value set on alignment interrupt. And the patch is to enable/collect correct DAR value when running with Little Endian PR guest. Now to limit the impact and to enable Little Endian PR guest, I ended up doing the conditional code only for book3s 64 for which we know for sure that we set DAR value. -aneesh From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from e28smtp07.in.ibm.com (e28smtp07.in.ibm.com [122.248.162.7]) (using TLSv1 with cipher DHE-RSA-AES256-SHA (256/256 bits)) (No client certificate requested) by ozlabs.org (Postfix) with ESMTPS id 7ED771402C9 for ; Tue, 6 May 2014 00:26:30 +1000 (EST) Received: from /spool/local by e28smtp07.in.ibm.com with IBM ESMTP SMTP Gateway: Authorized Use Only! Violators will be prosecuted for from ; Mon, 5 May 2014 19:56:27 +0530 Received: from d28relay03.in.ibm.com (d28relay03.in.ibm.com [9.184.220.60]) by d28dlp03.in.ibm.com (Postfix) with ESMTP id 0FC211258059 for ; Mon, 5 May 2014 19:55:20 +0530 (IST) Received: from d28av01.in.ibm.com (d28av01.in.ibm.com [9.184.220.63]) by d28relay03.in.ibm.com (8.13.8/8.13.8/NCO v10.0) with ESMTP id s45EQRv050331744 for ; Mon, 5 May 2014 19:56:27 +0530 Received: from d28av01.in.ibm.com (localhost [127.0.0.1]) by d28av01.in.ibm.com (8.14.4/8.14.4/NCO v10.0 AVout) with ESMTP id s45EQNNJ020567 for ; Mon, 5 May 2014 19:56:23 +0530 From: "Aneesh Kumar K.V" To: Alexander Graf Subject: Re: [PATCH V4] POWERPC: BOOK3S: KVM: Use the saved dar value and generic make_dsisr In-Reply-To: <536773C2.1070502@suse.de> References: <1399224075-18041-1-git-send-email-aneesh.kumar@linux.vnet.ibm.com> <536773C2.1070502@suse.de> Date: Mon, 05 May 2014 19:56:22 +0530 Message-ID: <87tx949u9d.fsf@linux.vnet.ibm.com> MIME-Version: 1.0 Content-Type: text/plain Cc: paulus@samba.org, linuxppc-dev@lists.ozlabs.org, kvm-ppc@vger.kernel.org, kvm@vger.kernel.org List-Id: Linux on PowerPC Developers Mail List List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Alexander Graf writes: > On 05/04/2014 07:21 PM, Aneesh Kumar K.V wrote: >> Although it's optional IBM POWER cpus always had DAR value set on >> alignment interrupt. So don't try to compute these values. >> >> Signed-off-by: Aneesh Kumar K.V >> --- >> Changes from V3: >> * Use make_dsisr instead of checking feature flag to decide whether to use >> saved dsisr or not >> .... >> ulong kvmppc_alignment_dar(struct kvm_vcpu *vcpu, unsigned int inst) >> { >> +#ifdef CONFIG_PPC_BOOK3S_64 >> + return vcpu->arch.fault_dar; > > How about PA6T and G5s? > > Paul mentioned that BOOK3S always had DAR value set on alignment interrupt. And the patch is to enable/collect correct DAR value when running with Little Endian PR guest. Now to limit the impact and to enable Little Endian PR guest, I ended up doing the conditional code only for book3s 64 for which we know for sure that we set DAR value. -aneesh From mboxrd@z Thu Jan 1 00:00:00 1970 From: "Aneesh Kumar K.V" Subject: Re: [PATCH V4] POWERPC: BOOK3S: KVM: Use the saved dar value and generic make_dsisr Date: Mon, 05 May 2014 19:56:22 +0530 Message-ID: <87tx949u9d.fsf@linux.vnet.ibm.com> References: <1399224075-18041-1-git-send-email-aneesh.kumar@linux.vnet.ibm.com> <536773C2.1070502@suse.de> Mime-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: base64 Cc: paulus@samba.org, linuxppc-dev@lists.ozlabs.org, kvm-ppc@vger.kernel.org, kvm@vger.kernel.org To: Alexander Graf Return-path: In-Reply-To: <536773C2.1070502@suse.de> List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: linuxppc-dev-bounces+glppd-linuxppc64-dev=m.gmane.org@lists.ozlabs.org Sender: "Linuxppc-dev" List-Id: kvm.vger.kernel.org QWxleGFuZGVyIEdyYWYgPGFncmFmQHN1c2UuZGU+IHdyaXRlczoKCj4gT24gMDUvMDQvMjAxNCAw NzoyMSBQTSwgQW5lZXNoIEt1bWFyIEsuViB3cm90ZToKPj4gQWx0aG91Z2ggaXQncyBvcHRpb25h bCBJQk0gUE9XRVIgY3B1cyBhbHdheXMgaGFkIERBUiB2YWx1ZSBzZXQgb24KPj4gYWxpZ25tZW50 IGludGVycnVwdC4gU28gZG9uJ3QgdHJ5IHRvIGNvbXB1dGUgdGhlc2UgdmFsdWVzLgo+Pgo+PiBT aWduZWQtb2ZmLWJ5OiBBbmVlc2ggS3VtYXIgSy5WIDxhbmVlc2gua3VtYXJAbGludXgudm5ldC5p Ym0uY29tPgo+PiAtLS0KPj4gQ2hhbmdlcyBmcm9tIFYzOgo+PiAqIFVzZSBtYWtlX2RzaXNyIGlu c3RlYWQgb2YgY2hlY2tpbmcgZmVhdHVyZSBmbGFnIHRvIGRlY2lkZSB3aGV0aGVyIHRvIHVzZQo+ PiAgICBzYXZlZCBkc2lzciBvciBub3QKPj4KCi4uLi4KCj4+ICAgdWxvbmcga3ZtcHBjX2FsaWdu bWVudF9kYXIoc3RydWN0IGt2bV92Y3B1ICp2Y3B1LCB1bnNpZ25lZCBpbnQgaW5zdCkKPj4gICB7 Cj4+ICsjaWZkZWYgQ09ORklHX1BQQ19CT09LM1NfNjQKPj4gKwlyZXR1cm4gdmNwdS0+YXJjaC5m YXVsdF9kYXI7Cj4KPiBIb3cgYWJvdXQgUEE2VCBhbmQgRzVzPwo+Cj4KClBhdWwgbWVudGlvbmVk IHRoYXQgQk9PSzNTIGFsd2F5cyBoYWQgREFSIHZhbHVlIHNldCBvbiBhbGlnbm1lbnQKaW50ZXJy dXB0LiBBbmQgdGhlIHBhdGNoIGlzIHRvIGVuYWJsZS9jb2xsZWN0IGNvcnJlY3QgREFSIHZhbHVl IHdoZW4KcnVubmluZyB3aXRoIExpdHRsZSBFbmRpYW4gUFIgZ3Vlc3QuIE5vdyB0byBsaW1pdCB0 aGUgaW1wYWN0IGFuZCB0bwplbmFibGUgTGl0dGxlIEVuZGlhbiBQUiBndWVzdCwgSSBlbmRlZCB1 cCBkb2luZyB0aGUgY29uZGl0aW9uYWwgY29kZQpvbmx5IGZvciBib29rM3MgNjQgZm9yIHdoaWNo IHdlIGtub3cgZm9yIHN1cmUgdGhhdCB3ZSBzZXQgREFSIHZhbHVlLgoKLWFuZWVzaAoKX19fX19f X19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX18KTGludXhwcGMtZGV2IG1h aWxpbmcgbGlzdApMaW51eHBwYy1kZXZAbGlzdHMub3psYWJzLm9yZwpodHRwczovL2xpc3RzLm96 bGFicy5vcmcvbGlzdGluZm8vbGludXhwcGMtZGV2