From: Markus Armbruster <armbru@redhat.com>
To: Luiz Capitulino <lcapitulino@redhat.com>
Cc: peter.maydell@linaro.org, qemu-devel@nongnu.org
Subject: Re: [Qemu-devel] [PATCH] tests/qapi-schema: Fix enum misuse in flat union type tests
Date: Tue, 11 Mar 2014 10:19:20 +0100 [thread overview]
Message-ID: <87txb5w0rr.fsf@blackfin.pond.sub.org> (raw)
In-Reply-To: <20140310121642.3a28896e@redhat.com> (Luiz Capitulino's message of "Mon, 10 Mar 2014 12:16:42 -0400")
Luiz Capitulino <lcapitulino@redhat.com> writes:
> On Mon, 10 Mar 2014 15:54:50 +0100
> Markus Armbruster <armbru@redhat.com> wrote:
>
>> Screwed up in commit 2fc0043. Currently harmless, because the enum
>> values happen to be identical.
>
> I'm afraid this conflicts with Wenchao's series:
>
> [PATCH V9 00/10] qapi script: support enum as discriminator and
> better enum name
>
> Which is already merged in my qmp queue:
>
> git://repo.or.cz/qemu/qmp-unstable.git queue/qmp
Conflicts because it fixes the bug silently.
If we want a record of the bug fix, we can either rebase his series on
top of mine, or amend one of his commit messages. I'm not sure it's
worth the bother, though. I can give it a try if you think it's
worthwhile.
next prev parent reply other threads:[~2014-03-11 9:19 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-03-10 14:54 [Qemu-devel] [PATCH] tests/qapi-schema: Fix enum misuse in flat union type tests Markus Armbruster
2014-03-10 16:16 ` Luiz Capitulino
2014-03-11 9:19 ` Markus Armbruster [this message]
2014-03-11 13:13 ` Luiz Capitulino
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=87txb5w0rr.fsf@blackfin.pond.sub.org \
--to=armbru@redhat.com \
--cc=lcapitulino@redhat.com \
--cc=peter.maydell@linaro.org \
--cc=qemu-devel@nongnu.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.