Re: [PATCH] drm/i915: Use symbolic names for booleans in i915_semaphore_is_enabled

[Jani Nikula <jani.nikula@linux.intel.com>]

On Tue, 17 Dec 2013, Daniel Vetter <daniel.vetter@ffwll.ch> wrote:
> Noticed while reviewing a patch and couldn't resist the OCD.

Reviewed-by: Jani Nikula <jani.nikula@intel.com>

> Signed-off-by: Daniel Vetter <daniel.vetter@ffwll.ch>
> ---
>  drivers/gpu/drm/i915/i915_drv.c | 6 +++---
>  1 file changed, 3 insertions(+), 3 deletions(-)
>
> diff --git a/drivers/gpu/drm/i915/i915_drv.c b/drivers/gpu/drm/i915/i915_drv.c
> index aea909b2f22e..31ffe39d2b79 100644
> --- a/drivers/gpu/drm/i915/i915_drv.c
> +++ b/drivers/gpu/drm/i915/i915_drv.c
> @@ -480,12 +480,12 @@ check_next:
>  bool i915_semaphore_is_enabled(struct drm_device *dev)
>  {
>  	if (INTEL_INFO(dev)->gen < 6)
> -		return 0;
> +		return false;
>  
>  	/* Until we get further testing... */
>  	if (IS_GEN8(dev)) {
>  		WARN_ON(!i915_preliminary_hw_support);
> -		return 0;
> +		return false;
>  	}
>  
>  	if (i915_semaphores >= 0)
> @@ -497,7 +497,7 @@ bool i915_semaphore_is_enabled(struct drm_device *dev)
>  		return false;
>  #endif
>  
> -	return 1;
> +	return true;
>  }
>  
>  static int i915_drm_freeze(struct drm_device *dev)
> -- 
> 1.8.4.3
>
> _______________________________________________
> Intel-gfx mailing list
> Intel-gfx@lists.freedesktop.org
> http://lists.freedesktop.org/mailman/listinfo/intel-gfx

-- 
Jani Nikula, Intel Open Source Technology Center