From: "Bjørn Mork" <bjorn@mork.no>
To: Dan Carpenter <dan.carpenter@oracle.com>
Cc: devel@driverdev.osuosl.org, netdev@vger.kernel.org,
Forest Bond <forest@alittletooquiet.net>,
Greg Kroah-Hartman <gregkh@linuxfoundation.org>
Subject: Re: [PATCH net-next 10/10] staging: vt6656: inherit addr_assign_type along with dev_addr
Date: Fri, 23 Aug 2013 14:06:21 +0200 [thread overview]
Message-ID: <87txig3936.fsf@nemi.mork.no> (raw)
In-Reply-To: <20130823111500.GC4713@mwanda> (Dan Carpenter's message of "Fri, 23 Aug 2013 14:15:00 +0300")
Dan Carpenter <dan.carpenter@oracle.com> writes:
> Ah... Here is the first patch which adds eth_hw_addr_inherit()
>
> http://patchwork.ozlabs.org/patch/269365/
>
> I don't think we've actually set dst->addr_len yet at this point so
> it doesn't do the memcpy(). This doesn't work.
Ouch. Yes, I see. The net_device is allocated using kzalloc just a few
lines earlier and there is no ether_setup or similar. Actually, it
doesn't look like it ever sets addr_len. Is that right? Does it work
even before this patch?
Anyway, thanks for spotting this. I'll drop this patch for now as I
clearly don't understand how this driver works.
I do note that the otherwise very similar code in the vt6655 driver uses
alloc_etherdev, and therefore has a fair chance of working both before
and after my change.
Bjørn
_______________________________________________
devel mailing list
devel@linuxdriverproject.org
http://driverdev.linuxdriverproject.org/mailman/listinfo/driverdev-devel
next prev parent reply other threads:[~2013-08-23 12:06 UTC|newest]
Thread overview: 24+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-08-23 9:35 [PATCH net-next 00/10] set addr_assign_type when inheriting a dev_addr Bjørn Mork
2013-08-23 9:35 ` Bjørn Mork
2013-08-23 9:35 ` [PATCH net-next 01/10] net: etherdevice: add address inherit helper Bjørn Mork
2013-08-23 19:24 ` Stephen Hemminger
2013-08-23 22:28 ` Bjørn Mork
2013-08-27 18:35 ` David Miller
2013-08-28 7:17 ` Bjørn Mork
2013-08-23 9:35 ` [PATCH net-next 02/10] net: vlan: inherit addr_assign_type along with dev_addr Bjørn Mork
2013-08-23 9:35 ` [PATCH net-next 03/10] net: dsa: " Bjørn Mork
2013-08-23 9:35 ` [PATCH net-next 04/10] net: macvlan: " Bjørn Mork
2013-08-23 9:35 ` [PATCH net-next 05/10] net: team: " Bjørn Mork
2013-08-23 9:35 ` [PATCH net-next 06/10] net: airo: " Bjørn Mork
2013-08-23 14:53 ` John W. Linville
2013-08-23 14:53 ` John W. Linville
2013-08-23 9:35 ` [PATCH net-next 07/10] net: hostap: " Bjørn Mork
2013-08-23 9:35 ` [PATCH net-next 08/10] net: libertas: " Bjørn Mork
2013-08-23 14:52 ` John W. Linville
2013-08-23 9:35 ` [PATCH net-next 09/10] staging: vt6655: " Bjørn Mork
2013-08-23 9:35 ` [PATCH net-next 10/10] staging: vt6656: " Bjørn Mork
2013-08-23 10:03 ` Dan Carpenter
2013-08-23 10:48 ` Bjørn Mork
2013-08-23 11:15 ` Dan Carpenter
2013-08-23 12:06 ` Bjørn Mork [this message]
2013-08-23 12:09 ` Dan Carpenter
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=87txig3936.fsf@nemi.mork.no \
--to=bjorn@mork.no \
--cc=dan.carpenter@oracle.com \
--cc=devel@driverdev.osuosl.org \
--cc=forest@alittletooquiet.net \
--cc=gregkh@linuxfoundation.org \
--cc=netdev@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.