From: Kevin Hilman <khilman@linaro.org>
To: Julia Lawall <Julia.Lawall@lip6.fr>
Cc: Santosh Shilimkar <santosh.shilimkar@ti.com>,
kernel-janitors@vger.kernel.org,
Linus Walleij <linus.walleij@linaro.org>,
linux-omap@vger.kernel.org, linux-gpio@vger.kernel.org,
linux-kernel@vger.kernel.org
Subject: Re: [PATCH 1/5 v2] drivers/gpio/gpio-omap.c: convert comma to semicolon
Date: Tue, 13 Aug 2013 15:07:46 +0000 [thread overview]
Message-ID: <87txitochp.fsf@kernel.org> (raw)
In-Reply-To: <1376378216-18473-1-git-send-email-Julia.Lawall@lip6.fr> (Julia Lawall's message of "Tue, 13 Aug 2013 09:16:56 +0200")
Julia Lawall <Julia.Lawall@lip6.fr> writes:
> From: Julia Lawall <Julia.Lawall@lip6.fr>
>
> Replace a comma between expression statements by a semicolon. This changes
> the semantics of the code, but given the current indentation appears to be
> what is intended.
>
> A simplified version of the semantic patch that performs this
> transformation is as follows: (http://coccinelle.lip6.fr/)
>
> // <smpl>
> @r@
> expression e1,e2,e;
> type T;
> identifier i;
> @@
>
> e1
> -,
> +;
> e2;
> // </smpl>
>
> Signed-off-by: Julia Lawall <Julia.Lawall@lip6.fr>
>
> ---
> Not tested. The first version did a different transformation to avoid
> changing the semantics. This one leaves the layout as it is, but changes
> the semantics.
This is the right one, the previous semantics were wrong due to a
copy/paste error.
Acked-by: Kevin Hilman <khilman@linaro.org>
> drivers/gpio/gpio-omap.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/drivers/gpio/gpio-omap.c b/drivers/gpio/gpio-omap.c
> index dfeb3a3..9f19ec9 100644
> --- a/drivers/gpio/gpio-omap.c
> +++ b/drivers/gpio/gpio-omap.c
> @@ -1030,7 +1030,7 @@ omap_mpuio_alloc_gc(struct gpio_bank *bank, unsigned int irq_start,
> ct->chip.irq_set_type = gpio_irq_type;
>
> if (bank->regs->wkup_en)
> - ct->chip.irq_set_wake = gpio_wake_enable,
> + ct->chip.irq_set_wake = gpio_wake_enable;
>
> ct->regs.mask = OMAP_MPUIO_GPIO_INT / bank->stride;
> irq_setup_generic_chip(gc, IRQ_MSK(num), IRQ_GC_INIT_MASK_CACHE,
> --
> To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
> the body of a message to majordomo@vger.kernel.org
> More majordomo info at http://vger.kernel.org/majordomo-info.html
> Please read the FAQ at http://www.tux.org/lkml/
WARNING: multiple messages have this Message-ID (diff)
From: Kevin Hilman <khilman@linaro.org>
To: Julia Lawall <Julia.Lawall@lip6.fr>
Cc: Santosh Shilimkar <santosh.shilimkar@ti.com>,
kernel-janitors@vger.kernel.org,
Linus Walleij <linus.walleij@linaro.org>,
linux-omap@vger.kernel.org, linux-gpio@vger.kernel.org,
linux-kernel@vger.kernel.org
Subject: Re: [PATCH 1/5 v2] drivers/gpio/gpio-omap.c: convert comma to semicolon
Date: Tue, 13 Aug 2013 08:07:46 -0700 [thread overview]
Message-ID: <87txitochp.fsf@kernel.org> (raw)
In-Reply-To: <1376378216-18473-1-git-send-email-Julia.Lawall@lip6.fr> (Julia Lawall's message of "Tue, 13 Aug 2013 09:16:56 +0200")
Julia Lawall <Julia.Lawall@lip6.fr> writes:
> From: Julia Lawall <Julia.Lawall@lip6.fr>
>
> Replace a comma between expression statements by a semicolon. This changes
> the semantics of the code, but given the current indentation appears to be
> what is intended.
>
> A simplified version of the semantic patch that performs this
> transformation is as follows: (http://coccinelle.lip6.fr/)
>
> // <smpl>
> @r@
> expression e1,e2,e;
> type T;
> identifier i;
> @@
>
> e1
> -,
> +;
> e2;
> // </smpl>
>
> Signed-off-by: Julia Lawall <Julia.Lawall@lip6.fr>
>
> ---
> Not tested. The first version did a different transformation to avoid
> changing the semantics. This one leaves the layout as it is, but changes
> the semantics.
This is the right one, the previous semantics were wrong due to a
copy/paste error.
Acked-by: Kevin Hilman <khilman@linaro.org>
> drivers/gpio/gpio-omap.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/drivers/gpio/gpio-omap.c b/drivers/gpio/gpio-omap.c
> index dfeb3a3..9f19ec9 100644
> --- a/drivers/gpio/gpio-omap.c
> +++ b/drivers/gpio/gpio-omap.c
> @@ -1030,7 +1030,7 @@ omap_mpuio_alloc_gc(struct gpio_bank *bank, unsigned int irq_start,
> ct->chip.irq_set_type = gpio_irq_type;
>
> if (bank->regs->wkup_en)
> - ct->chip.irq_set_wake = gpio_wake_enable,
> + ct->chip.irq_set_wake = gpio_wake_enable;
>
> ct->regs.mask = OMAP_MPUIO_GPIO_INT / bank->stride;
> irq_setup_generic_chip(gc, IRQ_MSK(num), IRQ_GC_INIT_MASK_CACHE,
> --
> To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
> the body of a message to majordomo@vger.kernel.org
> More majordomo info at http://vger.kernel.org/majordomo-info.html
> Please read the FAQ at http://www.tux.org/lkml/
next prev parent reply other threads:[~2013-08-13 15:07 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-08-13 7:16 [PATCH 1/5 v2] drivers/gpio/gpio-omap.c: convert comma to semicolon Julia Lawall
2013-08-13 7:16 ` Julia Lawall
2013-08-13 15:07 ` Kevin Hilman [this message]
2013-08-13 15:07 ` Kevin Hilman
2013-08-16 15:15 ` Linus Walleij
2013-08-16 15:15 ` Linus Walleij
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=87txitochp.fsf@kernel.org \
--to=khilman@linaro.org \
--cc=Julia.Lawall@lip6.fr \
--cc=kernel-janitors@vger.kernel.org \
--cc=linus.walleij@linaro.org \
--cc=linux-gpio@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-omap@vger.kernel.org \
--cc=santosh.shilimkar@ti.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.