From: Jani Nikula <jani.nikula@linux.intel.com>
To: Intel Graphics Development <intel-gfx@lists.freedesktop.org>
Cc: Daniel Vetter <daniel.vetter@ffwll.ch>, Jan Niggemann <jn@hz6.de>,
Egbert Eich <eich@suse.com>
Subject: Re: [PATCH] drm/i915: fix gen4 digital port hotplug definitions
Date: Fri, 26 Jul 2013 13:21:48 +0300 [thread overview]
Message-ID: <87txjh62pv.fsf@intel.com> (raw)
In-Reply-To: <1374830869-4891-1-git-send-email-daniel.vetter@ffwll.ch>
On Fri, 26 Jul 2013, Daniel Vetter <daniel.vetter@ffwll.ch> wrote:
> Apparently Bspec is wrong in this case here even for gm45. Note that
> Bspec is horribly misguided on i965g/gm, so we don't have any other
> data points besides that it seems to make machines work better.
>
> With this changes all the bits in PORT_HOTPLUG_STAT for the digital
> ports are ordered the same way. This seems to agree with what register
> dumps from the hpd storm handling code shows, where the LIVE bit and
> the short/long pulse STATUS bits light up at the same time with this
> enumeration (but no with the one from Bspec).
Would a comment about this near the #defines be in order? To avoid the
"these values are all wrong per bspec" patches.
Cheers,
Jani.
> Also tested on my gm45 which has two DP+ ports, and everything seems
> to still work as expected.
>
> References: http://www.mail-archive.com/intel-gfx@lists.freedesktop.org/msg23054.html
> Cc: Egbert Eich <eich@suse.com>
> Cc: Jan Niggemann <jn@hz6.de>
> Tested-by: Jan Niggemann <jn@hz6.de>
> Signed-off-by: Daniel Vetter <daniel.vetter@ffwll.ch>
> ---
> drivers/gpu/drm/i915/i915_reg.h | 4 ++--
> 1 file changed, 2 insertions(+), 2 deletions(-)
>
> diff --git a/drivers/gpu/drm/i915/i915_reg.h b/drivers/gpu/drm/i915/i915_reg.h
> index 6caa748..2d4c884 100644
> --- a/drivers/gpu/drm/i915/i915_reg.h
> +++ b/drivers/gpu/drm/i915/i915_reg.h
> @@ -1925,9 +1925,9 @@
>
> #define PORT_HOTPLUG_STAT (dev_priv->info->display_mmio_offset + 0x61114)
> /* HDMI/DP bits are gen4+ */
> -#define PORTB_HOTPLUG_LIVE_STATUS (1 << 29)
> +#define PORTD_HOTPLUG_LIVE_STATUS (1 << 29)
> #define PORTC_HOTPLUG_LIVE_STATUS (1 << 28)
> -#define PORTD_HOTPLUG_LIVE_STATUS (1 << 27)
> +#define PORTB_HOTPLUG_LIVE_STATUS (1 << 27)
> #define PORTD_HOTPLUG_INT_STATUS (3 << 21)
> #define PORTC_HOTPLUG_INT_STATUS (3 << 19)
> #define PORTB_HOTPLUG_INT_STATUS (3 << 17)
> --
> 1.8.3.2
>
> _______________________________________________
> Intel-gfx mailing list
> Intel-gfx@lists.freedesktop.org
> http://lists.freedesktop.org/mailman/listinfo/intel-gfx
--
Jani Nikula, Intel Open Source Technology Center
next prev parent reply other threads:[~2013-07-26 10:20 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-07-26 9:27 [PATCH] drm/i915: fix gen4 digital port hotplug definitions Daniel Vetter
2013-07-26 10:21 ` Jani Nikula [this message]
2013-07-26 17:54 ` Daniel Vetter
2013-07-26 19:46 ` Daniel Vetter
2013-09-06 8:38 ` Jan Niggemann
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=87txjh62pv.fsf@intel.com \
--to=jani.nikula@linux.intel.com \
--cc=daniel.vetter@ffwll.ch \
--cc=eich@suse.com \
--cc=intel-gfx@lists.freedesktop.org \
--cc=jn@hz6.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.