From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([2001:4830:134:3::10]:43332) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1UwHIX-000227-2Y for qemu-devel@nongnu.org; Mon, 08 Jul 2013 15:40:34 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1UwHIU-0006jW-PL for qemu-devel@nongnu.org; Mon, 08 Jul 2013 15:40:33 -0400 Received: from e35.co.us.ibm.com ([32.97.110.153]:33717) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1UwHIU-0006jR-Jd for qemu-devel@nongnu.org; Mon, 08 Jul 2013 15:40:30 -0400 Received: from /spool/local by e35.co.us.ibm.com with IBM ESMTP SMTP Gateway: Authorized Use Only! Violators will be prosecuted for from ; Mon, 8 Jul 2013 13:30:27 -0600 Received: from d01relay04.pok.ibm.com (d01relay04.pok.ibm.com [9.56.227.236]) by d03dlp01.boulder.ibm.com (Postfix) with ESMTP id 60BB31FF001F for ; Mon, 8 Jul 2013 13:24:36 -0600 (MDT) Received: from d03av03.boulder.ibm.com (d03av03.boulder.ibm.com [9.17.195.169]) by d01relay04.pok.ibm.com (8.13.8/8.13.8/NCO v10.0) with ESMTP id r68JPxEK157222 for ; Mon, 8 Jul 2013 15:26:00 -0400 Received: from d03av03.boulder.ibm.com (loopback [127.0.0.1]) by d03av03.boulder.ibm.com (8.14.4/8.13.1/NCO v10.0 AVout) with ESMTP id r68JPvH9027688 for ; Mon, 8 Jul 2013 13:25:58 -0600 From: Anthony Liguori In-Reply-To: <51DB0CD1.7030501@redhat.com> References: <1372931597-28115-1-git-send-email-gaowanlong@cn.fujitsu.com> <1372931597-28115-2-git-send-email-gaowanlong@cn.fujitsu.com> <20130705184115.GP13956@otherpad.lan.raisama.net> <51DB0CD1.7030501@redhat.com> Date: Mon, 08 Jul 2013 14:25:53 -0500 Message-ID: <87txk4q2f2.fsf@codemonkey.ws> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Subject: Re: [Qemu-devel] [PATCH V4 01/10] NUMA: Support multiple CPU ranges on -numa option List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: Eric Blake , Eduardo Habkost Cc: qemu-devel@nongnu.org, lcapitulino@redhat.com, bsd@redhat.com, pbonzini@redhat.com, y-goto@jp.fujitsu.com, afaerber@suse.de, Wanlong Gao Eric Blake writes: > On 07/05/2013 12:41 PM, Eduardo Habkost wrote: >> On Thu, Jul 04, 2013 at 05:53:08PM +0800, Wanlong Gao wrote: >>> From: Bandan Das >>> >>> This allows us to use the "cpus" property multiple times >>> to specify multiple cpu (ranges) to the -numa option : >>> >>> -numa node,cpus=1,cpus=2,cpus=4 >>> or >>> -numa node,cpus=1-3,cpus=5 >>> >>> Note that after this patch, the defalut suffix of "-numa node,mem=N" >>> will no longer be "M". So we must add the suffix "M" like "-numa node,mem=NM" >>> when assigning "N MB" of node memory size. >> >> Such an incompatible change is not acceptable, as it would break >> existing configurations. libvirt doesn't specify any suffix and expects >> it to always mean "MB". > > Newer libvirt can be taught to append 'M' when it detects it is talking > to newer qemu. While you have a point that it is annoying to force > users to upgrade to a newer libvirt merely because they upgraded qemu, > the libvirt point of view is that the following are supported: > > old libvirt -> old qemu > new libvirt -> old qemu > new libvirt -> new qemu > > but that this combination is always best effort and not required to work: > > old libvirt -> new qemu That's fine for libvirt, but we don't break command line compatibility in QEMU. So this patch needs to change. Regards, Anthony Liguori > > -- > Eric Blake eblake redhat com +1-919-301-3266 > Libvirt virtualization library http://libvirt.org