From mboxrd@z Thu Jan 1 00:00:00 1970 From: Rusty Russell Subject: Re: [virtio-spec PATCH 0/5] Receiving Used Buffers example code: cleanups and an extra mb() Date: Mon, 17 Jun 2013 11:47:13 +0930 Message-ID: <87txkxpjkm.fsf@rustcorp.com.au> References: <1370713168-20624-1-git-send-email-lersek@redhat.com> Mime-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Return-path: In-Reply-To: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: virtualization-bounces@lists.linux-foundation.org Errors-To: virtualization-bounces@lists.linux-foundation.org To: Stefan Hajnoczi , Laszlo Ersek Cc: Jordan Justen , Stefan Hajnoczi , Linux Virtualization List-Id: virtualization@lists.linuxfoundation.org Stefan Hajnoczi writes: > On Sat, Jun 8, 2013 at 7:39 PM, Laszlo Ersek wrote: >> Patches before the last are small cleanups. >> >> In the last patch I'm trying to extract / generalize an idea from Stefan >> Hajnoczi's review of my virtio-net driver for OVMF. How about a single patch which just replaces the completely broken example? :) >> Receiving Used Buffers: prevent speculative load when not >> sequentially consistent Yes, though this only needs to be a rmb(). In the OASIS 1.0 spec, I'd like an appendix with tested code for doing these operations (probably based on a simplifeid version of vringh.c). Thanks, Rusty.