From mboxrd@z Thu Jan  1 00:00:00 1970
Received: from eggs.gnu.org ([2001:4830:134:3::10]:32768)
	by lists.gnu.org with esmtp (Exim 4.71)
	(envelope-from <armbru@redhat.com>) id 1UjnNJ-0005XR-1C
	for qemu-devel@nongnu.org; Tue, 04 Jun 2013 05:17:55 -0400
Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71)
	(envelope-from <armbru@redhat.com>) id 1UjnNH-0007xT-3y
	for qemu-devel@nongnu.org; Tue, 04 Jun 2013 05:17:52 -0400
Received: from mx1.redhat.com ([209.132.183.28]:57573)
	by eggs.gnu.org with esmtp (Exim 4.71)
	(envelope-from <armbru@redhat.com>) id 1UjnNG-0007x7-RD
	for qemu-devel@nongnu.org; Tue, 04 Jun 2013 05:17:51 -0400
From: Markus Armbruster <armbru@redhat.com>
References: <1370272748-10629-1-git-send-email-pbonzini@redhat.com>
	<1370272748-10629-2-git-send-email-pbonzini@redhat.com>
	<CAFe8ug-KO-g02ykaHFxYtB7SFOJYit8j_m-qweMfc9aYks_0HA@mail.gmail.com>
Date: Tue, 04 Jun 2013 11:17:46 +0200
In-Reply-To: <CAFe8ug-KO-g02ykaHFxYtB7SFOJYit8j_m-qweMfc9aYks_0HA@mail.gmail.com>
	(Jordan Justen's message of "Mon, 3 Jun 2013 13:36:18 -0700")
Message-ID: <87txleutdx.fsf@blackfin.pond.sub.org>
MIME-Version: 1.0
Content-Type: text/plain
Subject: Re: [Qemu-devel] [PATCH 1/3] sysfw: remove read-only
	pc_sysfw_flash_vs_rom_bug_compatible
List-Id: <qemu-devel.nongnu.org>
List-Unsubscribe: <https://lists.nongnu.org/mailman/options/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=unsubscribe>
List-Archive: <http://lists.nongnu.org/archive/html/qemu-devel>
List-Post: <mailto:qemu-devel@nongnu.org>
List-Help: <mailto:qemu-devel-request@nongnu.org?subject=help>
List-Subscribe: <https://lists.nongnu.org/mailman/listinfo/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=subscribe>
To: Jordan Justen <jljusten@gmail.com>
Cc: Paolo Bonzini <pbonzini@redhat.com>, qemu-devel <qemu-devel@nongnu.org>, Jordan Justen <jordan.l.justen@intel.com>

Jordan Justen <jljusten@gmail.com> writes:

> On Mon, Jun 3, 2013 at 8:19 AM, Paolo Bonzini <pbonzini@redhat.com> wrote:
>> The variable is not written anymore.
>>
>> Signed-off-by: Paolo Bonzini <pbonzini@redhat.com>
>> ---
>>  hw/block/pc_sysfw.c | 26 +-------------------------
>>  1 file changed, 1 insertion(+), 25 deletions(-)
>>
>> diff --git a/hw/block/pc_sysfw.c b/hw/block/pc_sysfw.c
>> index 412d1b0..c6d4be4 100644
>> --- a/hw/block/pc_sysfw.c
>> +++ b/hw/block/pc_sysfw.c
>> @@ -199,12 +199,6 @@ static void old_pc_system_rom_init(MemoryRegion *rom_memory, bool isapc_ram_fw)
>>                                  bios);
>>  }
>>
>> -/*
>> - * Bug-compatible flash vs. ROM selection enabled?
>> - * A few older machines enable this.
>> - */
>> -bool pc_sysfw_flash_vs_rom_bug_compatible;
>
> Hmm. I think we still need this to retain the 1.2-1.5 compatible
> behavior. But, I think I maybe my kvm readonly series didn't properly
> resurrect the pc_sysfw_flash_vs_rom_bug_compatible switch.

It didn't (and its commit message failed to mention it tries).

Anyway, Paolo successfully argued for breaking backward compatibility:
http://lists.nongnu.org/archive/html/qemu-devel/2013-05/msg02074.html