From mboxrd@z Thu Jan  1 00:00:00 1970
Received: from eggs.gnu.org ([208.118.235.92]:58438)
	by lists.gnu.org with esmtp (Exim 4.71)
	(envelope-from <armbru@redhat.com>) id 1UHxZo-0003yy-Iq
	for qemu-devel@nongnu.org; Tue, 19 Mar 2013 10:31:45 -0400
Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71)
	(envelope-from <armbru@redhat.com>) id 1UHxZn-000760-5e
	for qemu-devel@nongnu.org; Tue, 19 Mar 2013 10:31:44 -0400
Received: from mx1.redhat.com ([209.132.183.28]:12870)
	by eggs.gnu.org with esmtp (Exim 4.71)
	(envelope-from <armbru@redhat.com>) id 1UHxZm-00075s-Ta
	for qemu-devel@nongnu.org; Tue, 19 Mar 2013 10:31:43 -0400
From: Markus Armbruster <armbru@redhat.com>
References: <1363109492-1901-1-git-send-email-chouteau@adacore.com>
	<1363109492-1901-4-git-send-email-chouteau@adacore.com>
	<87mwu6z7ze.fsf@blackfin.pond.sub.org> <5141AD9B.3060702@adacore.com>
	<8738vyw46r.fsf@blackfin.pond.sub.org> <5141FBC0.6050905@adacore.com>
Date: Tue, 19 Mar 2013 15:31:39 +0100
In-Reply-To: <5141FBC0.6050905@adacore.com> (Fabien Chouteau's message of
	"Thu, 14 Mar 2013 17:33:04 +0100")
Message-ID: <87txo731h0.fsf@blackfin.pond.sub.org>
MIME-Version: 1.0
Content-Type: text/plain
Subject: Re: [Qemu-devel] [PATCH V3 3/3] New option -gdb-opts
List-Id: <qemu-devel.nongnu.org>
List-Unsubscribe: <https://lists.nongnu.org/mailman/options/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=unsubscribe>
List-Archive: <http://lists.nongnu.org/archive/html/qemu-devel>
List-Post: <mailto:qemu-devel@nongnu.org>
List-Help: <mailto:qemu-devel-request@nongnu.org?subject=help>
List-Subscribe: <https://lists.nongnu.org/mailman/listinfo/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=subscribe>
To: Fabien Chouteau <chouteau@adacore.com>
Cc: jan.kiszka@siemens.com, qemu-devel@nongnu.org

Fabien Chouteau <chouteau@adacore.com> writes:

> On 03/14/2013 01:34 PM, Markus Armbruster wrote:
>> Fabien Chouteau <chouteau@adacore.com> writes:
>> 
>>> On 03/14/2013 09:44 AM, Markus Armbruster wrote:
>>>> Fabien Chouteau <chouteau@adacore.com> writes:
>>>>
>>>>> We introduce a new command line option. It's a generic option to
>>>>> customize the gdb server:
>>>>>
>>>>> -gdb-opts [attached=on|off]
>>>>>
>>>>> The only parameter for now is "attached".
>>>>>
>>>>> Signed-off-by: Fabien Chouteau <chouteau@adacore.com>
>>>>
>>>> --gdb-opts complements existing --gdb.  You need to use both for full
>>>> control.
>>>>
>>>> I figure you do this because you can't extend --gdb, as its argument is
>>>> in legacy character device syntax, not QemuOpts.
>>>>
>>>
>>> That's right, maybe we can do some string manipulations to handle this case.
>>>
>>> -gdb tcp::1234,attached=off
>>>
>>> find ',attached={on|off}' and remove it from the string.
>>
>> That way is madness :)
>
> Come on, you've seen worse ;)

Seen?  Perpetrated!  Stared madness in the eye, decided not to come back
for more ;)

>>>> We had similar cases before, and solved them differently: create a more
>>>> general option, then make the old one sugar for the new one.
>>>>
>>>> For instance, --monitor and --qmp are sugar for --mon.  Desugaring code
>>>> is in monitor_parse().
>>>>
>>>
>>> Something like:
>>>
>>> -chardev socket,id=gdb1,host=localhost,port=1234,server,nowait,nodelay
>>> -gdb-remote chardev=gdb1,attached=off
>>>
>>> You still need two options for full control.
>> 
>> Yes, but following precedence is good.  Our command line is inconsistent
>> enough as it is.  Just my two cents.
>> 
>
> Fair enough, lets forget about the option this is too much work. I'll
> just tweak the sources on our branch.

Pity.