From: Jani Nikula <jani.nikula@linux.intel.com>
To: Ben Widawsky <ben@bwidawsk.net>, Daniel Vetter <daniel@ffwll.ch>
Cc: intel-gfx@lists.freedesktop.org
Subject: Re: [PATCH 2/2] drm/i915: Adding a warning to FBC description
Date: Wed, 30 Jan 2013 16:18:39 +0200 [thread overview]
Message-ID: <87txpyeou8.fsf@intel.com> (raw)
In-Reply-To: <20130129085039.00001e00@unknown>
On Tue, 29 Jan 2013, Ben Widawsky <ben@bwidawsk.net> wrote:
> On Tue, 29 Jan 2013 09:49:13 +0100
> Daniel Vetter <daniel@ffwll.ch> wrote:
>
>> On Mon, Jan 28, 2013 at 03:32:16PM -0800, Ben Widawsky wrote:
>> > It should only be used with caution...
>> >
>> > Signed-off-by: Ben Widawsky <ben@bwidawsk.net>
>>
>> Isn't that like the general assumption of these module parameters that
>> they can have pretty massive bad side-effects? Meaning I'm routinely
>> checking these already anyway in bug reports, same for non-standard
>> rc6 settings.
>> -Daniel
>>
>
> I felt that way too, until we got a complain in #intel-gfx and it
> changed my mind.
>
> Whatevs, I ain't gonna fight for this one, I'll just punt the bug
> reporter to you next time.
Yeah, I agree it's *our* general assumption that these may have bad
side-effects. People just see the random forum posts recommending this
and that module param, and stick them in... Hmm, which means they won't
read that warning anyway. DRM_INFO("don't report a bug about this") when
enabling a feature that's disabled by default on a platform?
Jani.
next prev parent reply other threads:[~2013-01-30 14:18 UTC|newest]
Thread overview: 13+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-01-28 23:32 [PATCH 1/2] drm/i915: Error state should print /sys/kernel/debug Ben Widawsky
2013-01-28 23:32 ` [PATCH 2/2] drm/i915: Adding a warning to FBC description Ben Widawsky
2013-01-29 8:49 ` Daniel Vetter
2013-01-29 16:50 ` Ben Widawsky
2013-01-30 14:18 ` Jani Nikula [this message]
2013-01-31 3:13 ` Ben Widawsky
2013-01-31 15:37 ` Daniel Vetter
2013-01-29 0:14 ` [PATCH 1/2] drm/i915: Error state should print /sys/kernel/debug Carl Worth
2013-01-29 8:41 ` Damien Lespiau
2013-01-29 8:54 ` Daniel Vetter
2013-01-29 9:22 ` Jani Nikula
2013-01-29 16:52 ` Ben Widawsky
2013-01-29 17:05 ` Ville Syrjälä
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=87txpyeou8.fsf@intel.com \
--to=jani.nikula@linux.intel.com \
--cc=ben@bwidawsk.net \
--cc=daniel@ffwll.ch \
--cc=intel-gfx@lists.freedesktop.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.