From mboxrd@z Thu Jan  1 00:00:00 1970
Received: from eggs.gnu.org ([208.118.235.92]:36637)
	by lists.gnu.org with esmtp (Exim 4.71)
	(envelope-from <armbru@redhat.com>) id 1TdP1Y-0007nI-B5
	for qemu-devel@nongnu.org; Tue, 27 Nov 2012 12:32:51 -0500
Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71)
	(envelope-from <armbru@redhat.com>) id 1TdP1S-0007kE-FD
	for qemu-devel@nongnu.org; Tue, 27 Nov 2012 12:32:44 -0500
Received: from mx1.redhat.com ([209.132.183.28]:58808)
	by eggs.gnu.org with esmtp (Exim 4.71)
	(envelope-from <armbru@redhat.com>) id 1TdP1S-0007jv-7s
	for qemu-devel@nongnu.org; Tue, 27 Nov 2012 12:32:38 -0500
Received: from int-mx01.intmail.prod.int.phx2.redhat.com
	(int-mx01.intmail.prod.int.phx2.redhat.com [10.5.11.11])
	by mx1.redhat.com (8.14.4/8.14.4) with ESMTP id qARHWaXw018560
	(version=TLSv1/SSLv3 cipher=DHE-RSA-AES256-SHA bits=256 verify=OK)
	for <qemu-devel@nongnu.org>; Tue, 27 Nov 2012 12:32:37 -0500
From: Markus Armbruster <armbru@redhat.com>
References: <1354005293-17741-1-git-send-email-pbonzini@redhat.com>
	<50B4E1F7.4060000@redhat.com>
Date: Tue, 27 Nov 2012 17:49:59 +0100
In-Reply-To: <50B4E1F7.4060000@redhat.com> (Avi Kivity's message of "Tue, 27
	Nov 2012 17:53:27 +0200")
Message-ID: <87txsb56tk.fsf@blackfin.pond.sub.org>
MIME-Version: 1.0
Content-Type: text/plain
Subject: Re: [Qemu-devel] [PATCH 1.3] build: compile translate.o at -O1
	optimization
List-Id: <qemu-devel.nongnu.org>
List-Unsubscribe: <https://lists.nongnu.org/mailman/options/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=unsubscribe>
List-Archive: <http://lists.nongnu.org/archive/html/qemu-devel>
List-Post: <mailto:qemu-devel@nongnu.org>
List-Help: <mailto:qemu-devel-request@nongnu.org?subject=help>
List-Subscribe: <https://lists.nongnu.org/mailman/listinfo/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=subscribe>
To: Avi Kivity <avi@redhat.com>
Cc: Paolo Bonzini <pbonzini@redhat.com>, qemu-devel@nongnu.org

Avi Kivity <avi@redhat.com> writes:

> On 11/27/2012 10:34 AM, Paolo Bonzini wrote:
>> Some versions of GCC require insane (>2GB) amounts of memory
>> to compile translate.o.  As a countermeasure, compile it
>> with -O1.  This should fix the buildbot failure for
>> default_x86_64_fedora16.
>> 
>> Signed-off-by: Paolo Bonzini <pbonzini@redhat.com>
>> ---
>>  Makefile.target | 2 ++
>>  1 file changed, 2 insertions(+)
>> 
>> diff --git a/Makefile.target b/Makefile.target
>> index 8b658c0..3981931 100644
>> --- a/Makefile.target
>> +++ b/Makefile.target
>> @@ -143,6 +143,8 @@ GENERATED_HEADERS += hmp-commands.h qmp-commands-old.h
>>  
>>  endif # CONFIG_SOFTMMU
>>  
>> +%/translate.o: CFLAGS := $(patsubst -O2,-O1,$(CFLAGS))
>> +
>
> This may change some string argument in CFLAGS, for example an argument
> to -I.
>
> How about:
>
>   CFLAGS_opt = -O2
>   CFLAGS += $(CFLAGS_opt)
>   ...
>   %/translate.o: CFLAGS_opt = -O1

Just append -O1 to CFLAGS; the last -O wins.