From mboxrd@z Thu Jan  1 00:00:00 1970
From: Mika Kuoppala <mika.kuoppala@linux.intel.com>
Subject: Re: [PATCH] drm/i915: Set guardband clipping workaround
	bit in the right register.
Date: Tue, 09 Oct 2012 10:43:10 +0300
Message-ID: <87txu4ks4x.fsf@rosetta.fi.intel.com>
References: <1349504795.4898.17.camel@mattotaupa>
	<1349625067-4677-1-git-send-email-kenneth@whitecape.org>
Mime-Version: 1.0
Content-Type: text/plain; charset="us-ascii"
Content-Transfer-Encoding: 7bit
Return-path: <intel-gfx-bounces+gcfxdi-intel-gfx=m.gmane.org@lists.freedesktop.org>
Received: from mga11.intel.com (mga11.intel.com [192.55.52.93])
	by gabe.freedesktop.org (Postfix) with ESMTP id C00FD9F574
	for <intel-gfx@lists.freedesktop.org>;
	Tue,  9 Oct 2012 00:43:03 -0700 (PDT)
In-Reply-To: <1349625067-4677-1-git-send-email-kenneth@whitecape.org>
List-Unsubscribe: <http://lists.freedesktop.org/mailman/options/intel-gfx>,
	<mailto:intel-gfx-request@lists.freedesktop.org?subject=unsubscribe>
List-Archive: <http://lists.freedesktop.org/archives/intel-gfx>
List-Post: <mailto:intel-gfx@lists.freedesktop.org>
List-Help: <mailto:intel-gfx-request@lists.freedesktop.org?subject=help>
List-Subscribe: <http://lists.freedesktop.org/mailman/listinfo/intel-gfx>,
	<mailto:intel-gfx-request@lists.freedesktop.org?subject=subscribe>
Sender: intel-gfx-bounces+gcfxdi-intel-gfx=m.gmane.org@lists.freedesktop.org
Errors-To: intel-gfx-bounces+gcfxdi-intel-gfx=m.gmane.org@lists.freedesktop.org
To: Kenneth Graunke <kenneth@whitecape.org>, intel-gfx@lists.freedesktop.org
Cc: Daniel Vetter <daniel.vetter@ffwll.ch>, Oliver McFadden <oliver.mcfadden@linux.intel.com>
List-Id: intel-gfx@lists.freedesktop.org

On Sun,  7 Oct 2012 08:51:07 -0700, Kenneth Graunke <kenneth@whitecape.org> wrote:
> A previous patch, namely:
> 
> commit bf97b276ca04cee9ab65ffd378fa8e6aedd71ff6
> Author: Daniel Vetter <daniel.vetter@ffwll.ch>
> Date:   Wed Apr 11 20:42:41 2012 +0200
> 
>     drm/i915: implement w/a for incorrect guarband clipping
> 
> accidentally set bit 5 in 3D_CHICKEN, which has nothing to do with
> clipping.  This patch changes it to be set in 3D_CHICKEN3, where it
> belongs.
> 
> The game "Dante" demonstrates random clipping issues when guardband
> clipping is enabled and bit 5 of 3D_CHICKEN3 isn't set.  So the
> workaround is actually necessary.
> 
> Cc: Daniel Vetter <daniel.vetter@ffwll.ch>
> Cc: Oliver McFadden <oliver.mcfadden@linux.intel.com>
> Acked-by: Paul Menzel <paulepanter@users.sourceforge.net>
> Signed-off-by: Kenneth Graunke <kenneth@whitecape.org>

Reviewed-by: Mika Kuoppala <mika.kuoppala@intel.com>