From: "Bjørn Mork" <bjorn@mork.no>
To: Steve Glendinning <steve@shawell.net>
Cc: netdev@vger.kernel.org
Subject: Re: [PATCH 5/5] smsc95xx: enable power saving mode during system suspend
Date: Wed, 26 Sep 2012 17:48:24 +0200 [thread overview]
Message-ID: <87txuk9453.fsf@nemi.mork.no> (raw)
In-Reply-To: <CAKh2mn5tKowqjbvgWDSz52UF9qY9_ysAb23Pb-M_3wvCG=_R6w@mail.gmail.com> (Steve Glendinning's message of "Wed, 26 Sep 2012 16:16:27 +0100")
Steve Glendinning <steve@shawell.net> writes:
> On 26 September 2012 15:23, Bjørn Mork <bjorn@mork.no> wrote:
>> Steve Glendinning <steve.glendinning@shawell.net> writes:
>>
>>> +static int smsc95xx_suspend(struct usb_interface *intf, pm_message_t message)
>>> +{
>>> + struct usbnet *dev = usb_get_intfdata(intf);
>>> + int ret;
>>> + u32 val;
>>> +
>>> + BUG_ON(!dev);
>>
>> That's not very user friendly. Why not just return here?
>
> I hadn't thought that was a situation that could arise, is it? Would
> this happen if the USB device was removed during suspend?
No, it should not happen. But then, why test at all?
Bjørn
next prev parent reply other threads:[~2012-09-26 15:48 UTC|newest]
Thread overview: 15+ messages / expand[flat|nested] mbox.gz Atom feed top
2012-09-26 12:40 [PATCH 0/5] smsc95xx enhancements (v2) Steve Glendinning
2012-09-26 12:40 ` [PATCH 1/5] smsc95xx: sleep before read for lengthy operations Steve Glendinning
2012-09-26 12:40 ` [PATCH 2/5] smsc95xx: remove unnecessary variables Steve Glendinning
2012-09-26 12:40 ` [PATCH 3/5] smsc95xx: check return code from control messages Steve Glendinning
2012-09-26 12:40 ` [PATCH 4/5] smsc95xx: fix resume when usb device is reset Steve Glendinning
2012-09-26 12:40 ` [PATCH 5/5] smsc95xx: enable power saving mode during system suspend Steve Glendinning
2012-09-26 14:23 ` Bjørn Mork
2012-09-26 15:16 ` Steve Glendinning
2012-09-26 15:48 ` Bjørn Mork [this message]
2012-09-26 15:58 ` Steve Glendinning
2012-09-26 16:17 ` Bjørn Mork
2012-09-27 8:04 ` Steve Glendinning
2012-09-27 17:14 ` Bjørn Mork
-- strict thread matches above, loose matches on Subject: below --
2012-09-24 14:40 [PATCH 0/5] smsc95xx enhancements Steve Glendinning
2012-09-24 14:40 ` [PATCH 5/5] smsc95xx: enable power saving mode during system suspend Steve Glendinning
2012-09-26 12:25 ` Steve Glendinning
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=87txuk9453.fsf@nemi.mork.no \
--to=bjorn@mork.no \
--cc=netdev@vger.kernel.org \
--cc=steve@shawell.net \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.