From: ebiederm@xmission.com (Eric W. Biederman)
To: Eric Dumazet <eric.dumazet@gmail.com>
Cc: netdev@vger.kernel.org
Subject: Re: netlink scm creds uid and gids are always 0.
Date: Fri, 24 Aug 2012 01:19:32 -0700 [thread overview]
Message-ID: <87txvsk8h7.fsf@xmission.com> (raw)
In-Reply-To: <1345795065.5904.2287.camel@edumazet-glaptop> (Eric Dumazet's message of "Fri, 24 Aug 2012 09:57:45 +0200")
Eric Dumazet <eric.dumazet@gmail.com> writes:
> On Thu, 2012-08-23 at 23:45 -0700, Eric W. Biederman wrote:
>> While working on the kuid_t and kgid_t conversion of the audit subsystem
>> I noticed that since the performance problem of scm creds and af_unix
>> sockets were fixed af_netlink sockets have not filled in the uid or gid
>> of the originator of the socket.
>>
>> I think all we need is an appropriate cred_to_ucred call to fix this
>> regression, but I am going so many different directions right now I
>> can't get myself to focus on this long enough to work up an appripriate
>> patch to fix.
>>
>> Eric do you think you might take a gander?
>
> Wasnt it fixed by e0e3cea46d31d23dc40df0a49a7a2c04fe8edfea
>
> af_netlink: force credentials passing [CVE-2012-3520]
>
> Or is it a different thing ?
Same thing. I didn't see that fix go by.
One more little thing I can cross off my list. Hooray!
Eric
next prev parent reply other threads:[~2012-08-24 8:19 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2012-08-24 6:45 netlink scm creds uid and gids are always 0 Eric W. Biederman
2012-08-24 7:57 ` Eric Dumazet
2012-08-24 8:19 ` Eric W. Biederman [this message]
2012-08-24 9:07 ` Eric W. Biederman
2012-08-24 9:45 ` David Laight
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=87txvsk8h7.fsf@xmission.com \
--to=ebiederm@xmission.com \
--cc=eric.dumazet@gmail.com \
--cc=netdev@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.