From mboxrd@z Thu Jan 1 00:00:00 1970 From: Rusty Russell Subject: Re: [PATCH v6 09/11] virtio: net: Add freeze, restore handlers to support S4 Date: Wed, 04 Jan 2012 13:19:47 +1030 Message-ID: <87ty4cchbo.fsf@rustcorp.com.au> References: <20111229161523.GB2300@redhat.com> <20111230085205.GG4576@amit.redhat.com> <20120101114727.GC25350@redhat.com> <20120103170748.GE4536@amit.redhat.com> Mime-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Return-path: In-Reply-To: <20120103170748.GE4536@amit.redhat.com> List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: virtualization-bounces@lists.linux-foundation.org Errors-To: virtualization-bounces@lists.linux-foundation.org To: Amit Shah , "Michael S. Tsirkin" Cc: netdev , linux-pm@vger.kernel.org, linux-kernel@vger.kernel.org, Virtualization List List-Id: virtualization@lists.linuxfoundation.org On Tue, 3 Jan 2012 22:37:48 +0530, Amit Shah wrote: > On (Sun) 01 Jan 2012 [13:47:27], Michael S. Tsirkin wrote: > > On Fri, Dec 30, 2011 at 03:08:19PM +0530, Amit Shah wrote: > > > > > > > > > + if (!try_fill_recv(vi, GFP_KERNEL)) > > > > > + schedule_delayed_work(&vi->refill, 0); > > > > > > > > This needs to be switched to non reentrant wq too? > > > > > > Subsequent invocations could create problems? Note that this will be > > > the first item to be queued in the workqueue for the refill work. > > > > > > Amit > > > > See recent patches on net-next. > > We switched other calls to a non reentrant wq so I think same > > reasoning applies there. > > There's a patch ordering issue; so this series should land after the > -net series is merged. > > Rusty, do you want me to re-spin this patch on top of yours, or is > that something that you'll handle? Indeed, this can't go via -net, since it needs the virtio-pci patches which change power management. I've changed that one line, and will post those patches for DaveM's ack. Thanks, Rusty. From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1755258Ab2ADC5q (ORCPT ); Tue, 3 Jan 2012 21:57:46 -0500 Received: from ozlabs.org ([203.10.76.45]:45157 "EHLO ozlabs.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1754098Ab2ADC5m (ORCPT ); Tue, 3 Jan 2012 21:57:42 -0500 From: Rusty Russell To: Amit Shah , "Michael S. Tsirkin" Cc: Virtualization List , linux-kernel@vger.kernel.org, linux-pm@vger.kernel.org, netdev Subject: Re: [PATCH v6 09/11] virtio: net: Add freeze, restore handlers to support S4 In-Reply-To: <20120103170748.GE4536@amit.redhat.com> References: <20111229161523.GB2300@redhat.com> <20111230085205.GG4576@amit.redhat.com> <20120101114727.GC25350@redhat.com> <20120103170748.GE4536@amit.redhat.com> User-Agent: Notmuch/0.6.1-1 (http://notmuchmail.org) Emacs/23.3.1 (i686-pc-linux-gnu) Date: Wed, 04 Jan 2012 13:19:47 +1030 Message-ID: <87ty4cchbo.fsf@rustcorp.com.au> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Tue, 3 Jan 2012 22:37:48 +0530, Amit Shah wrote: > On (Sun) 01 Jan 2012 [13:47:27], Michael S. Tsirkin wrote: > > On Fri, Dec 30, 2011 at 03:08:19PM +0530, Amit Shah wrote: > > > > > > > > > + if (!try_fill_recv(vi, GFP_KERNEL)) > > > > > + schedule_delayed_work(&vi->refill, 0); > > > > > > > > This needs to be switched to non reentrant wq too? > > > > > > Subsequent invocations could create problems? Note that this will be > > > the first item to be queued in the workqueue for the refill work. > > > > > > Amit > > > > See recent patches on net-next. > > We switched other calls to a non reentrant wq so I think same > > reasoning applies there. > > There's a patch ordering issue; so this series should land after the > -net series is merged. > > Rusty, do you want me to re-spin this patch on top of yours, or is > that something that you'll handle? Indeed, this can't go via -net, since it needs the virtio-pci patches which change power management. I've changed that one line, and will post those patches for DaveM's ack. Thanks, Rusty.