From: Rusty Russell <rusty@rustcorp.com.au>
To: Jan Glauber <jang@linux.vnet.ibm.com>
Cc: Christoph Hellwig <hch@infradead.org>,
linux-kernel@vger.kernel.org, castet.matthieu@free.fr,
sliakh.lkml@gmail.com, jiang@cs.ncsu.edu, mingo@elte.hu
Subject: Re: Undoing module RONX protection fix
Date: Thu, 28 Apr 2011 21:06:39 +0930 [thread overview]
Message-ID: <87tyditxo8.fsf@rustcorp.com.au> (raw)
In-Reply-To: <1303985300.3495.93.camel@localhost.localdomain>
On Thu, 28 Apr 2011 12:08:20 +0200, Jan Glauber <jang@linux.vnet.ibm.com> wrote:
> How about this?
>
> To be honest I don't like the inverse naming like in unset no-execute
> too much, it makes me feel dizzy. But I wanted to keep the changes
> minimal.
Yes, it should probably just be called protect_module_pages and
unprotect_module_pages. The current names provide far too much
information.
But going back a bit, how did we end up with a NULL mod->module_init and
yet module->init_text_size, mod->init_size or mod->init_ro_size
non-zero?
Because if start == end, set_page_attributes() is a noop, right?
Confused,
Rusty.
next prev parent reply other threads:[~2011-04-28 12:46 UTC|newest]
Thread overview: 12+ messages / expand[flat|nested] mbox.gz Atom feed top
2011-04-18 9:23 Undoing module RONX protection Jan Glauber
2011-04-18 9:28 ` Christoph Hellwig
2011-04-18 10:43 ` Rusty Russell
2011-04-21 14:19 ` Jan Glauber
2011-04-27 5:12 ` Undoing module RONX protection fix Rusty Russell
2011-04-28 10:08 ` Jan Glauber
2011-04-28 11:36 ` Rusty Russell [this message]
2011-04-28 13:43 ` Jan Glauber
2011-04-29 4:41 ` Rusty Russell
2011-04-29 16:35 ` Jan Glauber
2011-04-30 6:13 ` Rusty Russell
2011-04-18 12:40 ` Undoing module RONX protection Jan Glauber
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=87tyditxo8.fsf@rustcorp.com.au \
--to=rusty@rustcorp.com.au \
--cc=castet.matthieu@free.fr \
--cc=hch@infradead.org \
--cc=jang@linux.vnet.ibm.com \
--cc=jiang@cs.ncsu.edu \
--cc=linux-kernel@vger.kernel.org \
--cc=mingo@elte.hu \
--cc=sliakh.lkml@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.