From: Peter Korsgaard <jacmet@sunsite.dk>
To: Baruch Siach <baruch@tkos.co.il>
Cc: dmitry.torokhov@gmail.com, linux-input@vger.kernel.org
Subject: Re: [PATCH] evdev: fix evdev_write return value on partial writes
Date: Thu, 27 Jan 2011 11:05:21 +0100 [thread overview]
Message-ID: <87tyguslum.fsf@macbook.be.48ers.dk> (raw)
In-Reply-To: <20110127094613.GE12588@jasper.tkos.co.il> (Baruch Siach's message of "Thu, 27 Jan 2011 11:46:13 +0200")
>>>>> "Baruch" == Baruch Siach <baruch@tkos.co.il> writes:
>> Fix it by only handling each full input_event structure, similar to
>> how it is done in evdev_read.
Baruch> A Reporte-by here would be nice.
Sorry, forgot. Dmitry, could you add it when you commit the patch.
>> Signed-off-by: Peter Korsgaard <jacmet@sunsite.dk>
Baruch> As I said on the Busybox list, applying this results in an endless
Baruch> write(1, "test\n", 5) = 0
Baruch> write(1, "test\n", 5) = 0
Baruch> write(1, "test\n", 5) = 0
Baruch> write(1, "test\n", 5) = 0
Baruch> write(1, "test\n", 5) = 0
Baruch> write(1, "test\n", 5) = 0
Baruch> write(1, "test\n", 5) = 0
Baruch> from the command
Baruch> echo test > /dev/input/event0
Baruch> write() should probably return -EINVAL here.
Indeed, like we do in evdev_read. Updated patch sent.
--
Bye, Peter Korsgaard
prev parent reply other threads:[~2011-01-27 10:05 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2011-01-27 9:42 [PATCH] evdev: fix evdev_write return value on partial writes Peter Korsgaard
2011-01-27 9:46 ` Baruch Siach
2011-01-27 10:05 ` Peter Korsgaard [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=87tyguslum.fsf@macbook.be.48ers.dk \
--to=jacmet@sunsite.dk \
--cc=baruch@tkos.co.il \
--cc=dmitry.torokhov@gmail.com \
--cc=linux-input@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.