All of lore.kernel.org
 help / color / mirror / Atom feed
From: "Štěpán Němec" <stepnem@gmail.com>
To: Yann Dirson <ydirson@altern.org>
Cc: git@vger.kernel.org
Subject: Re: [PATCH] Sync "git diff -h" with the manual, show options summary.
Date: Sun, 24 Oct 2010 17:15:09 +0200	[thread overview]
Message-ID: <87tykbpqpu.fsf@gmail.com> (raw)
In-Reply-To: <1287840825-6491-1-git-send-email-ydirson@altern.org> (Yann Dirson's message of "Sat, 23 Oct 2010 15:33:45 +0200")

Yann Dirson <ydirson@altern.org> writes:

> Signed-off-by: Yann Dirson <ydirson@altern.org>
> ---
>  builtin/diff.c |    3 ++-
>  1 files changed, 2 insertions(+), 1 deletions(-)
>
> diff --git a/builtin/diff.c b/builtin/diff.c
> index a43d326..8736225 100644
> --- a/builtin/diff.c
> +++ b/builtin/diff.c
> @@ -22,7 +22,8 @@ struct blobinfo {
>  };
>  
>  static const char builtin_diff_usage[] =
> -"git diff <options> <rev>{0,2} -- <path>*";
> +"git diff [<common diff options>] <commit>{0,2} -- <path>*"
> +COMMON_DIFF_OPTIONS_HELP;
>  
>  static void stuff_change(struct diff_options *opt,
>  			 unsigned old_mode, unsigned new_mode,

When at it, could you please also use [<path>...] instead of <path>*?
That's what the man pages and other usage strings use.

Štěpán

  parent reply	other threads:[~2010-10-24 15:19 UTC|newest]

Thread overview: 7+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2010-10-23 13:33 [PATCH] Sync "git diff -h" with the manual, show options summary Yann Dirson
2010-10-23 14:07 ` Yann Dirson
2010-10-23 18:02 ` Thiago Farina
2010-10-23 18:04   ` Matthieu Moy
2010-10-23 18:44     ` Yann Dirson
2010-10-24 15:15 ` Štěpán Němec [this message]
  -- strict thread matches above, loose matches on Subject: below --
2010-10-01  7:32 Yann Dirson

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=87tykbpqpu.fsf@gmail.com \
    --to=stepnem@gmail.com \
    --cc=git@vger.kernel.org \
    --cc=ydirson@altern.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.