All of lore.kernel.org
 help / color / mirror / Atom feed
From: Kalle Valo <kalle.valo@canonical.com>
To: ofono@ofono.org
Subject: Re: huawei e1550
Date: Wed, 13 Oct 2010 15:51:55 +0300	[thread overview]
Message-ID: <87tykqcl1w.fsf@potku.valot.fi> (raw)
In-Reply-To: <1286973748.10204.5.camel@mezon.ru>

[-- Attachment #1: Type: text/plain, Size: 931 bytes --]

Alexander A Khryukin <alexander@mezon.ru> writes:

> # patch -p1 < ofono.patch 
>
> patching file plugins/huawei.c
> Hunk #1 FAILED at 624.
> 1 out of 1 hunk FAILED -- saving rejects to file plugins/huawei.c.rej
>
> im using
> http://www.kernel.org/pub/linux/network/ofono/ofono-0.31.tar.bz2

My patch was against latest git. But I copy pasted the patch, maybe that
was the reason it failed. Here's a new one, this time against 0.31.

diff --git a/plugins/huawei.c b/plugins/huawei.c
index 12abdc6..3372454 100644
--- a/plugins/huawei.c
+++ b/plugins/huawei.c
@@ -617,8 +617,6 @@ static void huawei_post_online(struct ofono_modem *modem)
 								data->pcui);
 
 	ofono_sms_create(modem, OFONO_VENDOR_HUAWEI, "atmodem", data->pcui);
-	ofono_cbs_create(modem, OFONO_VENDOR_QUALCOMM_MSM,
-						"atmodem", data->pcui);
 	ofono_ussd_create(modem, OFONO_VENDOR_QUALCOMM_MSM,
 						"atmodem", data->pcui);
 

  reply	other threads:[~2010-10-13 12:51 UTC|newest]

Thread overview: 12+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2010-10-08 12:20 huawei e1550 Alexander A Khryukin
2010-10-08 12:43 ` Alexander A Khryukin
2010-10-08 18:25   ` Kalle Valo
2010-10-13 11:50     ` Alexander A Khryukin
2010-10-13 12:14       ` Kalle Valo
2010-10-13 12:42         ` Alexander A Khryukin
2010-10-13 12:51           ` Kalle Valo [this message]
2010-10-13 13:57             ` Alexander A Khryukin
2010-10-14  9:03             ` Alexander A Khryukin
2010-10-13 12:54         ` Alexander A Khryukin
2010-10-18  8:30           ` Alexander A Khryukin
2010-10-29 11:39             ` Alexander A Khryukin

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=87tykqcl1w.fsf@potku.valot.fi \
    --to=kalle.valo@canonical.com \
    --cc=ofono@ofono.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.