From mboxrd@z Thu Jan 1 00:00:00 1970 From: Francisco Jerez Subject: Re: [PATCH] drm/nouveau: try to load fbcon Date: Thu, 26 Aug 2010 00:39:36 +0200 Message-ID: <87tymi9v13.fsf@riseup.net> References: <87sk22brd2.fsf@riseup.net> <20100825181813.GA6991@joi.lan> Mime-Version: 1.0 Content-Type: multipart/mixed; boundary="===============0480060299==" Return-path: In-Reply-To: <20100825181813.GA6991-OI9uyE9O0yo@public.gmane.org> (Marcin Slusarz's message of "Wed, 25 Aug 2010 20:18:13 +0200") List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: nouveau-bounces+gcfxn-nouveau=m.gmane.org-PD4FTy7X32lNgt0PjOBp9y5qC8QIuHrW@public.gmane.org Errors-To: nouveau-bounces+gcfxn-nouveau=m.gmane.org-PD4FTy7X32lNgt0PjOBp9y5qC8QIuHrW@public.gmane.org To: Marcin Slusarz Cc: nouveau-PD4FTy7X32lNgt0PjOBp9y5qC8QIuHrW@public.gmane.org, Dragos Delcea List-Id: nouveau.vger.kernel.org --===============0480060299== Content-Type: multipart/signed; boundary="==-=-="; micalg=pgp-sha256; protocol="application/pgp-signature" --==-=-= Content-Type: multipart/mixed; boundary="=-=-=" --=-=-= Content-Type: text/plain; charset=utf-8 Content-Disposition: inline Content-Transfer-Encoding: quoted-printable Marcin Slusarz writes: > On Wed, Aug 25, 2010 at 06:15:53PM +0200, Francisco Jerez wrote: >> Dragos Delcea writes: >>=20 >> > Hi, >> > >> > I noticed that loading nouveau doesn't load fbcon automatically; and w= ithout fbcon, when loading nouveau the >> > console turns blank. I spent a few good hours until I was able to figu= re out that I had to manually modprobe >> > fbcon to get the console back after loading nouveau. >> > This is happening on a vanilla 2.6.35.3; shouldn't there be dependenci= es in place between modules? >> > >> > Note that I haven't got to the xorg part just yet, I'm currently insta= lling gentoo. >> > >> We already do, except for kernels compiled with "Configure standard >> kernel features (for small systems)". Strictly speaking, nouveau doesn't >> depend on fbcon so that option is left open for e.g. embedded platforms >> that don't need a framebuffer console. > > But it's only a build time dependency. Let's fix it. > > --- > From: Marcin Slusarz > Subject: [PATCH] drm/nouveau: try to load fbcon > > Currently users have to load fbcon manually or build it > into the kernel to have any console output. > Let's make it easy for them and load fbcon automatically > at init time. Nouveau already selects fbcon at build time > when !EMBEDDED. > > Reported-by: Dragos Delcea > Signed-off-by: Marcin Slusarz > --- > drivers/gpu/drm/nouveau/nouveau_drv.c | 6 ++++++ > 1 files changed, 6 insertions(+), 0 deletions(-) > > diff --git a/drivers/gpu/drm/nouveau/nouveau_drv.c b/drivers/gpu/drm/nouv= eau/nouveau_drv.c > index a8d3d17..df9a687 100644 > --- a/drivers/gpu/drm/nouveau/nouveau_drv.c > +++ b/drivers/gpu/drm/nouveau/nouveau_drv.c > @@ -434,6 +434,12 @@ static int __init nouveau_init(void) > if (!nouveau_modeset) > return 0; >=20=20 > +#if defined(CONFIG_FRAMEBUFFER_CONSOLE_MODULE) > + request_module("fbcon"); > +#elif !defined(CONFIG_FRAMEBUFFER_CONSOLE) > + printk(KERN_INFO "CONFIG_FRAMEBUFFER_CONSOLE was not enabled. You won't= get any console output.\n"); > +#endif > + > nouveau_register_dsm_handler(); > return drm_init(&driver); > } Pushed to master, thanks. --=-=-=-- --==-=-= Content-Type: application/pgp-signature -----BEGIN PGP SIGNATURE----- Version: GnuPG v1.4.10 (GNU/Linux) iF4EAREIAAYFAkx1m6gACgkQg5k4nX1Sv1sBYgD/dErcXc80tN8HuTuRNT30mnVQ LhRjQe6R1Fkp88TD87AA/j7d3ruMrtks71fTJhOigB+w68Vm4yl9lz8cwvqShFs6 =1bQZ -----END PGP SIGNATURE----- --==-=-=-- --===============0480060299== Content-Type: text/plain; charset="us-ascii" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit Content-Disposition: inline _______________________________________________ Nouveau mailing list Nouveau-PD4FTy7X32lNgt0PjOBp9y5qC8QIuHrW@public.gmane.org http://lists.freedesktop.org/mailman/listinfo/nouveau --===============0480060299==--