All of lore.kernel.org
 help / color / mirror / Atom feed
From: Kalle Valo <kvalo@adurom.com>
To: Sebastian Smolorz <Sebastian.Smolorz@gmx.de>
Cc: Johannes Berg <johannes@sipsolutions.net>,
	"John W. Linville" <linville@tuxdriver.com>,
	linux-wireless@vger.kernel.org,
	Marcel Holtmann <marcel@holtmann.org>
Subject: Re: [RFC] Changes in mac80211 to make at76c50x-usb working again
Date: Thu, 17 Jun 2010 09:27:16 +0300	[thread overview]
Message-ID: <87typ2fa2j.fsf@purkki.valot.fi> (raw)
In-Reply-To: <201006160946.54197.Sebastian.Smolorz@gmx.de> (Sebastian Smolorz's message of "Wed\, 16 Jun 2010 09\:46\:54 +0200")

Sebastian Smolorz <Sebastian.Smolorz@gmx.de> writes:

> Kalle Valo wrote:
>
>> I debugged this a long time ago. The problem is that firmware's
>> CMD_JOIN only works if bssid is correct one. I remember trying
>> ff:ff:ff:ff:ff:ff, but that didn't work for some reason. The join
>> command needs to be sent before association, otherwise transmission
>> won't work at all. And if I use a random bssid the firmware will
>> filter the replies. But I tested this a long time ago, I might
>> remember something wrong.
>> 
>> I was thinking a hack which would get bssid from association frames
>> and then send CMD_JOIN, before the association frame.
>
> Could you elaborate a little bit on this?

Basically my idea is this (all in tx path):

1. if tx frame is an association frame, get bssid from the frame
2. if bssid == priv->bssid, goto step 6
3. store tx frame, don't transmit it yet
4. send CMD_JOIN with new bssid
5. wait for command completion
6. priv->bssid = bssid
7. transmit tx frame
8. done

Ugly as hell, but one option to get the driver working again.

> How do we proceed to make the driver working again? Do you want to work on 
> this issue?

Sorry, currently I only have time to review patches and send comments.
If you have the time, it would be great to if you could fix the driver
finally.

-- 
Kalle Valo

  reply	other threads:[~2010-06-17  6:27 UTC|newest]

Thread overview: 11+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2010-06-15 12:16 [RFC] Changes in mac80211 to make at76c50x-usb working again Sebastian Smolorz
2010-06-15 13:26 ` John W. Linville
2010-06-15 13:36   ` Johannes Berg
2010-06-15 13:49     ` Sebastian Smolorz
2010-06-15 13:56       ` Johannes Berg
2010-06-15 14:11         ` Sebastian Smolorz
2010-06-15 14:21           ` Johannes Berg
2010-06-15 14:26     ` Kalle Valo
2010-06-16  7:46       ` Sebastian Smolorz
2010-06-17  6:27         ` Kalle Valo [this message]
2010-06-17  7:51           ` Sebastian Smolorz

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=87typ2fa2j.fsf@purkki.valot.fi \
    --to=kvalo@adurom.com \
    --cc=Sebastian.Smolorz@gmx.de \
    --cc=johannes@sipsolutions.net \
    --cc=linux-wireless@vger.kernel.org \
    --cc=linville@tuxdriver.com \
    --cc=marcel@holtmann.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.