All of lore.kernel.org
 help / color / mirror / Atom feed
From: Peter Korsgaard <jacmet@uclibc.org>
To: buildroot@busybox.net
Subject: [Buildroot] [PATCH] wpa_supplicant: adjust make environment for pkg-config call
Date: Mon, 05 Oct 2009 11:10:01 +0200	[thread overview]
Message-ID: <87tyye436e.fsf@macbook.be.48ers.dk> (raw)
In-Reply-To: <1254733230.5772.7.camel@sven> (Sven Neumann's message of "Mon\, 05 Oct 2009 11\:00\:30 +0200")

>>>>> "Sven" == Sven Neumann <s.neumann@raumfeld.com> writes:

Hi,

 >> Won't this pick up /usr/bin/pkg-config instead of the one in HOST_DIR? I
 >> would prefer to simply use TARGET_CONFIGURE_OPTS here so the path gets
 >> set and we only have the pkgconfig magic one place.

 Sven> The PATH is already set. Here's the relevant line from our log (with
 Sven> this change applied):

 Sven> PATH="/tmp/build/build/toolchain_build_arm/bin:/tmp/build/build/build_arm/host_dir/bin:/tmp/build/build/build_arm/host_dir/usr/bin:/tmp/build/build/build_arm/staging_dir/bin:/tmp/build/build/build_arm/staging_dir/usr/bin:/usr/local/bin:/usr/bin:/bin:/usr/games" PKG_CONFIG_SYSROOT_DIR="/tmp/build/build/build_arm/staging_dir" PKG_CONFIG_PATH="/tmp/build/build/build_arm/staging_dir/usr/lib/pkgconfig" /usr/bin/make -j4  -C /tmp/build/build/build_arm/wpa_supplicant-0.6.9/wpa_supplicant

Ahh yes, Makefile.autotools.in has:

PATH=$(TARGET_PATH) $($(PKG)_MAKE_ENV) $($(PKG)_MAKE) $($(PKG)_MAKE_OPT)
-C $(@D)/$($(PKG)_SUBDIR)

 Sven> But if you can come up with a cleaner solution, then please go ahead and
 Sven> commit it instead of my patch.

No - With that out of the way, then I think your patch is fine.

-- 
Bye, Peter Korsgaard

  reply	other threads:[~2009-10-05  9:10 UTC|newest]

Thread overview: 5+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2009-10-05  8:30 [Buildroot] [PATCH] wpa_supplicant: adjust make environment for pkg-config call Sven Neumann
2009-10-05  8:45 ` Peter Korsgaard
2009-10-05  9:00   ` Sven Neumann
2009-10-05  9:10     ` Peter Korsgaard [this message]
2009-10-05  9:10 ` Peter Korsgaard

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=87tyye436e.fsf@macbook.be.48ers.dk \
    --to=jacmet@uclibc.org \
    --cc=buildroot@busybox.net \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.