From mboxrd@z Thu Jan  1 00:00:00 1970
Received: from mailman by lists.gnu.org with tmda-scanned (Exim 4.43)
	id 1MbtKd-0005nm-1R
	for qemu-devel@nongnu.org; Fri, 14 Aug 2009 05:44:19 -0400
Received: from exim by lists.gnu.org with spam-scanned (Exim 4.43)
	id 1MbtKX-0005mU-MG
	for qemu-devel@nongnu.org; Fri, 14 Aug 2009 05:44:18 -0400
Received: from [199.232.76.173] (port=60994 helo=monty-python.gnu.org)
	by lists.gnu.org with esmtp (Exim 4.43) id 1MbtKX-0005mR-B6
	for qemu-devel@nongnu.org; Fri, 14 Aug 2009 05:44:13 -0400
Received: from mx2.redhat.com ([66.187.237.31]:53590)
	by monty-python.gnu.org with esmtp (Exim 4.60)
	(envelope-from <armbru@redhat.com>) id 1MbtKW-0005xe-Kh
	for qemu-devel@nongnu.org; Fri, 14 Aug 2009 05:44:12 -0400
Received: from int-mx2.corp.redhat.com (int-mx2.corp.redhat.com [172.16.27.26])
	by mx2.redhat.com (8.13.8/8.13.8) with ESMTP id n7E9iBA8014971
	for <qemu-devel@nongnu.org>; Fri, 14 Aug 2009 05:44:12 -0400
Subject: Re: [Qemu-devel] [PATCH] switch balloon initialization to -device.
References: <1250238862-1408-1-git-send-email-kraxel@redhat.com>
From: Markus Armbruster <armbru@redhat.com>
Date: Fri, 14 Aug 2009 11:44:09 +0200
In-Reply-To: <1250238862-1408-1-git-send-email-kraxel@redhat.com> (Gerd
	Hoffmann's message of "Fri\, 14 Aug 2009 10\:34\:22 +0200")
Message-ID: <87tz0alogm.fsf@pike.pond.sub.org>
MIME-Version: 1.0
Content-Type: text/plain; charset=us-ascii
List-Id: qemu-devel.nongnu.org
List-Unsubscribe: <http://lists.nongnu.org/mailman/listinfo/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=unsubscribe>
List-Archive: <http://lists.gnu.org/pipermail/qemu-devel>
List-Post: <mailto:qemu-devel@nongnu.org>
List-Help: <mailto:qemu-devel-request@nongnu.org?subject=help>
List-Subscribe: <http://lists.nongnu.org/mailman/listinfo/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=subscribe>
To: Gerd Hoffmann <kraxel@redhat.com>
Cc: qemu-devel@nongnu.org

Gerd Hoffmann <kraxel@redhat.com> writes:

> With that patch applied "-balloon virtio,args" becomes a shortcut for
> "-device virtio-balloon-pci,args".
>
> Side effects:
>  - ballon device gains support for id=<tag>.
>  - ballon device is off by default now.
>  - initialization order changes, which may in different pci slot
>    assignment depending on the VM configuration.
>
> Signed-off-by: Gerd Hoffmann <kraxel@redhat.com>

Looks good on quick inspection (gotta run), just one question: what
happens when I (stupidly) do -balloon virtio,driver=e1000 ?  Question
might apply to plain -device before this patch as well.