Re: [PATCH] omap: pm: Fix overflow when doing powerdomain deps lookups.

[Kevin Hilman <khilman@deeprootsystems.com>]

Mike Chan <mike@android.com> writes:

> Signed-off-by: Mike Chan <mike@android.com>
> ---
>  arch/arm/mach-omap2/powerdomain.c |    2 +-
>  1 files changed, 1 insertions(+), 1 deletions(-)
>
> diff --git a/arch/arm/mach-omap2/powerdomain.c b/arch/arm/mach-omap2/powerdomain.c
> index 0334609..6077629 100644
> --- a/arch/arm/mach-omap2/powerdomain.c
> +++ b/arch/arm/mach-omap2/powerdomain.c
> @@ -90,7 +90,7 @@ static struct powerdomain *_pwrdm_deps_lookup(struct powerdomain *pwrdm,
>  	if (!pwrdm || !deps || !omap_chip_is(pwrdm->omap_chip))
>  		return ERR_PTR(-EINVAL);
>  
> -	for (pd = deps; pd; pd++) {
> +	for (pd = deps; pd->pwrdm_name; pd++) {

Maybe should be:

	for (pd = deps; pd && pd->pwrdm_name; pd++) {

?

>  
>  		if (!omap_chip_is(pd->omap_chip))
>  			continue;

Also, a descriptive changelog would be helpful here describing the
conditions where you saw overflow etc.

Kevin