From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1760810AbZEMTFz (ORCPT ); Wed, 13 May 2009 15:05:55 -0400 Received: (majordomo@vger.kernel.org) by vger.kernel.org id S1760247AbZEMTFp (ORCPT ); Wed, 13 May 2009 15:05:45 -0400 Received: from mail-fx0-f158.google.com ([209.85.220.158]:48744 "EHLO mail-fx0-f158.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1759848AbZEMTFp (ORCPT ); Wed, 13 May 2009 15:05:45 -0400 DomainKey-Signature: a=rsa-sha1; c=nofws; d=gmail.com; s=gamma; h=date:message-id:from:to:cc:subject:in-reply-to:references :user-agent:mime-version:content-type; b=w44PjvIPGZSArvDhM7psPTPTaS4Ddk2Szf8gpOuj8vcGqWcm1LPBZf7+9Mn9BgFGST Sp/CveOWw8H2bxxmKTuTFAsRUpicg+JPrR1ZXSIdEwaWnQRla2d4rEjzRRfQx1/jaslG X9jqsw74gUKv1PtlVEa6/GOisOn5IChQbDu5Q= Date: Wed, 13 May 2009 21:05:43 +0200 Message-ID: <87tz3ozuuw.wl%vmayatsk@redhat.com> From: Vitaly Mayatskikh To: Roland McGrath Cc: Vitaly Mayatskikh , Andrew Morton , Oleg Nesterov , Ingo Molnar , linux-kernel@vger.kernel.org Subject: Re: [PATCH 1/3] Introduce "struct wait_info" to simplify wait_task*() pathes In-Reply-To: <20090513181358.39DC5FC35D@magilla.sf.frob.com> References: <1242216490-8226-1-git-send-email-v.mayatskih@gmail.com> <1242216490-8226-2-git-send-email-v.mayatskih@gmail.com> User-Agent: Wanderlust/2.15.6 (Almost Unreal) Emacs/22.3 Mule/5.0 (SAKAKI) MIME-Version: 1.0 (generated by SEMI 1.14.6 - "Maruoka") Content-Type: text/plain; charset=US-ASCII Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org At Wed, 13 May 2009 11:13:58 -0700 (PDT), Roland McGrath wrote: > What's the benefit of this? Those parameters are probably happily in > registers and compiled well, I would guess. Adding more memory copying > does not seem like a benefit. Have you verified that your change reduces > code size or something like that? Yeah, I was wrong. There's no benefit in size of .text -- wbr, Vitaly