All of lore.kernel.org
 help / color / mirror / Atom feed
From: Peter Korsgaard <jacmet@uclibc.org>
To: buildroot@busybox.net
Subject: [Buildroot] [PATCH] mDNSresponder cross-compilation
Date: Thu, 05 Mar 2009 11:59:54 +0100	[thread overview]
Message-ID: <87tz68fd5h.fsf@macbook.be.48ers.dk> (raw)
In-Reply-To: <206b9e70903031746n64eb2b82n459ca3092b12f6a1@mail.gmail.com> (Zac Wheeler's message of "Tue\, 3 Mar 2009 17\:46\:18 -0800")

>>>>> "Zac" == Zac Wheeler <zac.wheeler@gmail.com> writes:

 Zac> This patch fixes the mdnsresponder package from Apple so that it will
 Zac> cross-compile on arm. It also fixes an incorrect usage of $(PKG)_SITE.

 Zac> It is against the 2009.02 release.

Thanks, a few comments:

 Zac> +++ b/package/mdnsresponder/mDNSResponder-107.6-mdnsposix-ld-strip.patch
 Zac> @@ -0,0 +1,20 @@
 Zac> +--- mDNSResponder-107.6/mDNSPosix/Makefile.orig	2009-03-03 16:57:28.000000000 -0800
 Zac> ++++ mDNSResponder-107.6/mDNSPosix/Makefile	2009-03-03 16:56:16.000000000 -0800
 Zac> +@@ -268,7 +268,7 @@
 Zac> + JDK = /usr/jdk
 Zac> + 
 Zac> + CC = @cc
 Zac> +-LD = ld -shared
 Zac> ++LD = @ld -shared
 Zac> + CP = cp
 Zac> + RM = rm
 Zac> + LN = ln -s -f
 Zac> +@@ -293,7 +293,7 @@
 Zac> + CFLAGS_DEBUG = -Os -DMDNS_DEBUGMSGS=0 
 Zac> + OBJDIR = objects/prod
 Zac> + BUILDDIR = build/prod
 Zac> +-STRIP = strip -S 
 Zac> ++STRIP = @strip -S 

Why those @ ? Just purely cosmetic?

Isn't the .mk overrriding those variables on the cmdline anyway?

 Zac>  $(MDNSRESPONDER_DIR)/.built: $(MDNSRESPONDER_DIR)/.configured
 Zac> -	$(MAKE1) CC=$(TARGET_CC) os="linux" LD="$(TARGET_CC) -shared" LOCALBASE="/usr" -C $(MDNSRESPONDER_DIR)/mDNSPosix
 Zac> +	$(MAKE1) CC=$(TARGET_CC) os="linux" LD="$(TARGET_CC) -shared" STRIP=$(TARGET_STRIP) LOCALBASE="/usr" -C $(MDNSRESPONDER_DIR)/mDNSPosix

We normally use $(STRIPCMD) in package/ instead of $(TARGET_STRIP),
but OK.

-- 
Bye, Peter Korsgaard

      reply	other threads:[~2009-03-05 10:59 UTC|newest]

Thread overview: 2+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2009-03-04  1:46 [Buildroot] [PATCH] mDNSresponder cross-compilation Zac Wheeler
2009-03-05 10:59 ` Peter Korsgaard [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=87tz68fd5h.fsf@macbook.be.48ers.dk \
    --to=jacmet@uclibc.org \
    --cc=buildroot@busybox.net \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.