From: Kalle Valo <kalle.valo@iki.fi>
To: "John W. Linville" <linville@tuxdriver.com>
Cc: Mike Cui <cuicui@gmail.com>, linux-wireless@vger.kernel.org
Subject: Re: Bug in iw prevents setting the "cook" monitor flag
Date: Wed, 04 Mar 2009 12:04:39 +0200 [thread overview]
Message-ID: <87tz69six4.fsf@litku.valot.fi> (raw)
In-Reply-To: <20090303145233.GB17678@tuxdriver.com> (John W. Linville's message of "Tue\, 3 Mar 2009 09\:52\:33 -0500")
"John W. Linville" <linville@tuxdriver.com> writes:
> On Mon, Mar 02, 2009 at 03:16:14PM -0800, Mike Cui wrote:
>> There is an off by one error in interface.c of iw that prevents
>> passing of the cook flag when creating a monitor interface. The fix is
>> simple:
>>
>>
>> --- a/interface.c 2009-03-02 15:11:58.748078548 -0800
>> +++ b/interface.c 2009-03-02 15:12:14.695203787 -0800
[...]
> FWIW, I think I like "x <= Y" instead of "x < Y + 1".
I agree.
> Also, please make sure you are following the guidelines explained here:
>
> http://linux.yyz.us/patch-format.html
>
> In particular, I need a Signed-off-by line from you.
But this is for iw, not for wireless-testing. Or did I miss something?
--
Kalle Valo
next prev parent reply other threads:[~2009-03-04 10:04 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2009-03-02 23:16 Bug in iw prevents setting the "cook" monitor flag Mike Cui
2009-03-03 14:52 ` John W. Linville
2009-03-04 10:04 ` Kalle Valo [this message]
2009-03-04 14:14 ` John W. Linville
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=87tz69six4.fsf@litku.valot.fi \
--to=kalle.valo@iki.fi \
--cc=cuicui@gmail.com \
--cc=linux-wireless@vger.kernel.org \
--cc=linville@tuxdriver.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.