From: Robert Jarzmik <robert.jarzmik@free.fr>
To: roel kluin <roel.kluin@gmail.com>
Cc: video4linux-list@redhat.com,
Guennadi Liakhovetski <g.liakhovetski@gmx.de>,
mchehab@infradead.org
Subject: Re: [PATCH] mt9m111: mt9m111_get_global_gain() - unsigned <= 0 is always true
Date: Sat, 29 Nov 2008 13:28:03 +0100 [thread overview]
Message-ID: <87tz9qra24.fsf@free.fr> (raw)
In-Reply-To: <49311628.7090308@gmail.com> (roel kluin's message of "Sat\, 29 Nov 2008 05\:15\:04 -0500")
roel kluin <roel.kluin@gmail.com> writes:
> unsigned <= 0 is always true
>
> Signed-off-by: Roel Kluin <roel.kluin@gmail.com>
You're right, your patch is good, but ... there is another mistake I made which
should be also fixed.
The real formula is :
gain = (data & 0x2f) * (1 << ((data >> 10) & 1)) * (1 << ((data >> 9) & 1));
That is bits 9 and 10 give a 2x gain factor.
Would you please amend your patch to fix the formula please ?
--
Robert
--
video4linux-list mailing list
Unsubscribe mailto:video4linux-list-request@redhat.com?subject=unsubscribe
https://www.redhat.com/mailman/listinfo/video4linux-list
next parent reply other threads:[~2008-11-29 12:28 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
[not found] <49311628.7090308@gmail.com>
2008-11-29 12:28 ` Robert Jarzmik [this message]
[not found] ` <49313E77.3090209@gmail.com>
2008-11-29 14:23 ` [PATCH v2] mt9m111: mt9m111_get_global_gain() - unsigned <= 0 is always true Robert Jarzmik
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=87tz9qra24.fsf@free.fr \
--to=robert.jarzmik@free.fr \
--cc=g.liakhovetski@gmx.de \
--cc=mchehab@infradead.org \
--cc=roel.kluin@gmail.com \
--cc=video4linux-list@redhat.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.