From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from ey-out-2122.google.com (ey-out-2122.google.com [74.125.78.24]) by ozlabs.org (Postfix) with ESMTP id 373B3DDFC7 for ; Sat, 6 Sep 2008 04:45:39 +1000 (EST) Received: by ey-out-2122.google.com with SMTP id 6so218032eyi.15 for ; Fri, 05 Sep 2008 11:45:37 -0700 (PDT) To: avorontsov@ru.mvista.com Subject: Re: [PATCH] powerpc: gpio driver for mpc831x/834x/837x with OF bindings References: <1220627327-28852-1-git-send-email-jacmet@sunsite.dk> <20080905161607.GA10826@oksana.dev.rtsoft.ru> From: Peter Korsgaard Date: Fri, 05 Sep 2008 20:45:33 +0200 In-Reply-To: <20080905161607.GA10826@oksana.dev.rtsoft.ru> (Anton Vorontsov's message of "Fri\, 5 Sep 2008 20\:16\:07 +0400") Message-ID: <87tzcuctyq.fsf@macbook.be.48ers.dk> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Sender: Peter Korsgaard Cc: linuxppc-dev@ozlabs.org List-Id: Linux on PowerPC Developers Mail List List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , >>>>> "Anton" == Anton Vorontsov writes: Anton> On Fri, Sep 05, 2008 at 05:08:47PM +0200, Peter Korsgaard wrote: >> Structured similar to the existing QE GPIO support. >> >> Signed-off-by: Peter Korsgaard >> --- Anton> I posted identical driver in June. ;-) Anton> http://ozlabs.org/pipermail/linuxppc-dev/2008-June/057395.html Ahh, I must have missed it back then. Seems like you never got any feedback on it - Now, as we both independently got to ~same result, it must be a good approach ;) Kumar, what do you say? >>From a quick look, your driver seems to set the data / direction registers in the wrong order in fsl_gpio_dir_out causing a glitch with high level outputs: http://peter.korsgaard.com/patches/uboot/mpc83xx-gpio-level-before-direction.patch (Never seems to have made it to the U-Boot list archive, but it's in git now). -- Bye, Peter Korsgaard