From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mailman by lists.gnu.org with archive (Exim 4.43) id 1KETJA-000069-D9 for mharc-grub-devel@gnu.org; Thu, 03 Jul 2008 14:13:28 -0400 Received: from mailman by lists.gnu.org with tmda-scanned (Exim 4.43) id 1KETJ8-0008W7-0s for grub-devel@gnu.org; Thu, 03 Jul 2008 14:13:26 -0400 Received: from exim by lists.gnu.org with spam-scanned (Exim 4.43) id 1KETJ5-0008Us-R6 for grub-devel@gnu.org; Thu, 03 Jul 2008 14:13:24 -0400 Received: from [199.232.76.173] (port=47081 helo=monty-python.gnu.org) by lists.gnu.org with esmtp (Exim 4.43) id 1KETJ5-0008Up-E2 for grub-devel@gnu.org; Thu, 03 Jul 2008 14:13:23 -0400 Received: from smtp-vbr5.xs4all.nl ([194.109.24.25]:3132) by monty-python.gnu.org with esmtp (Exim 4.60) (envelope-from ) id 1KETJ5-00020B-8u for grub-devel@gnu.org; Thu, 03 Jul 2008 14:13:23 -0400 Received: from localhost.localdomain (249-174.surfsnel.dsl.internl.net [145.99.174.249]) by smtp-vbr5.xs4all.nl (8.13.8/8.13.8) with ESMTP id m63IDLAe040376 for ; Thu, 3 Jul 2008 20:13:22 +0200 (CEST) (envelope-from mgerards@xs4all.nl) From: Marco Gerards To: The development of GRUB 2 References: <20080702001046.7554.37059.stgit@dv.roinet.com> Mail-Copies-To: mgerards@xs4all.nl Date: Thu, 03 Jul 2008 20:21:43 +0200 In-Reply-To: <20080702001046.7554.37059.stgit@dv.roinet.com> (Pavel Roskin's message of "Tue, 01 Jul 2008 20:10:46 -0400") Message-ID: <87tzf66d6w.fsf@xs4all.nl> User-Agent: Gnus/5.110006 (No Gnus v0.6) Emacs/21.4 (gnu/linux) MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii X-Virus-Scanned: by XS4ALL Virus Scanner X-detected-kernel: by monty-python.gnu.org: FreeBSD 4.6-4.9 Subject: Re: [PATCH] Fix warning in fs/xfs.c X-BeenThere: grub-devel@gnu.org X-Mailman-Version: 2.1.5 Precedence: list Reply-To: The development of GRUB 2 List-Id: The development of GRUB 2 List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Thu, 03 Jul 2008 18:13:26 -0000 Pavel Roskin writes: > ChangeLog: > * fs/xfs.c (struct grub_xfs_dir_header): Use names similar to > those in Linux XFS code. Provide a way to access 64-bit parent > inode. > (grub_xfs_iterate_dir): Use the new names. Avoid reading past > the end of struct grub_xfs_dir_header. *please* do not look at Linux code or whatever *and* contribute to GRUB. It might cause copyright troubles I will have to deal with :-/ I do not see the advantage of this patch. Can you please explain why we need these name changes? -- Marco