From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mailman by lists.gnu.org with archive (Exim 4.43) id 1Ithvq-0005S0-90 for mharc-grub-devel@gnu.org; Sun, 18 Nov 2007 06:03:18 -0500 Received: from mailman by lists.gnu.org with tmda-scanned (Exim 4.43) id 1Ithvo-0005QR-E8 for grub-devel@gnu.org; Sun, 18 Nov 2007 06:03:16 -0500 Received: from exim by lists.gnu.org with spam-scanned (Exim 4.43) id 1Ithvm-0005OZ-5z for grub-devel@gnu.org; Sun, 18 Nov 2007 06:03:15 -0500 Received: from [199.232.76.173] (helo=monty-python.gnu.org) by lists.gnu.org with esmtp (Exim 4.43) id 1Ithvl-0005OD-LL for grub-devel@gnu.org; Sun, 18 Nov 2007 06:03:13 -0500 Received: from smtp-vbr5.xs4all.nl ([194.109.24.25]) by monty-python.gnu.org with esmtp (Exim 4.60) (envelope-from ) id 1Ithvl-0005EV-09 for grub-devel@gnu.org; Sun, 18 Nov 2007 06:03:13 -0500 Received: from localhost.localdomain (249-174.surfsnel.dsl.internl.net [145.99.174.249]) by smtp-vbr5.xs4all.nl (8.13.8/8.13.8) with ESMTP id lAIB3BXC060740 for ; Sun, 18 Nov 2007 12:03:12 +0100 (CET) (envelope-from mgerards@xs4all.nl) From: Marco Gerards To: The development of GRUB 2 References: <4735CDA9.4060501@t-online.de> <87wssqf39h.fsf@xs4all.nl> <47362686.6030407@t-online.de> Mail-Copies-To: mgerards@xs4all.nl Date: Sun, 18 Nov 2007 12:04:06 +0100 In-Reply-To: <47362686.6030407@t-online.de> (Christian Franke's message of "Sat, 10 Nov 2007 22:45:42 +0100") Message-ID: <87tznjstll.fsf@xs4all.nl> User-Agent: Gnus/5.110006 (No Gnus v0.6) Emacs/21.4 (gnu/linux) MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii X-Virus-Scanned: by XS4ALL Virus Scanner X-detected-kernel: by monty-python.gnu.org: FreeBSD 4.6-4.9 Subject: Re: [PATCH] Use getopt_long() instead of argp_parse() in grub-emu X-BeenThere: grub-devel@gnu.org X-Mailman-Version: 2.1.5 Precedence: list Reply-To: The development of GRUB 2 List-Id: The development of GRUB 2 List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Sun, 18 Nov 2007 11:03:16 -0000 Christian Franke writes: > Marco Gerards wrote: >> Christian Franke writes: >> >> >>> Unlike the other GRUB2 utils, grub-emu uses the glibc extension >>> argp_parse(). It is unavailable on Cygwin, which might also be the >>> case for other platforms where glibc is not the native runtime. >>> >> >> This has been brought up before, BSD has the same problem. The >> outcome of the discussion was (IIRC) that we will use argp. When argp >> is not available we can use gnulib or a standalone argp parser >> ("argp-standalone") to support this. In that case it will mean >> changing configure.ac. >> > > Will argp_parse() be a pre-requisite for building GRUB2 or will > argp-standalone be included (some other projects do) ? Personally, I would prefer it if it could be used as an external library. The more we include, the more we need to care about. > If you really want argp, why is it used only for the few trivial > options of grub-emu ? The other utils still use getopt_long(). > grub-emu does not benefit much from argp, but introduces another > portability issue. It's what happened :-) Perhaps we should consider getopt_long, for now. It's one file to change... Does anyone else object? Otherwise I'll review this patch. -- Marco