From mboxrd@z Thu Jan  1 00:00:00 1970
Received: from mailman by lists.gnu.org with archive (Exim 4.43)
	id 1IqsEg-0008Gs-HY
	for mharc-grub-devel@gnu.org; Sat, 10 Nov 2007 10:27:02 -0500
Received: from mailman by lists.gnu.org with tmda-scanned (Exim 4.43)
	id 1IqsEe-0008Db-CC
	for grub-devel@gnu.org; Sat, 10 Nov 2007 10:27:00 -0500
Received: from exim by lists.gnu.org with spam-scanned (Exim 4.43)
	id 1IqsEa-00088J-OC
	for grub-devel@gnu.org; Sat, 10 Nov 2007 10:26:59 -0500
Received: from [199.232.76.173] (helo=monty-python.gnu.org)
	by lists.gnu.org with esmtp (Exim 4.43) id 1IqsEa-000887-BZ
	for grub-devel@gnu.org; Sat, 10 Nov 2007 10:26:56 -0500
Received: from smtp-vbr12.xs4all.nl ([194.109.24.32])
	by monty-python.gnu.org with esmtp (Exim 4.60)
	(envelope-from <mgerards@xs4all.nl>) id 1IqsEZ-0002N1-Vg
	for grub-devel@gnu.org; Sat, 10 Nov 2007 10:26:56 -0500
Received: from localhost.localdomain (249-174.surfsnel.dsl.internl.net
	[145.99.174.249])
	by smtp-vbr12.xs4all.nl (8.13.8/8.13.8) with ESMTP id lAAFQsws002861
	for <grub-devel@gnu.org>; Sat, 10 Nov 2007 16:26:55 +0100 (CET)
	(envelope-from mgerards@xs4all.nl)
From: Marco Gerards <mgerards@xs4all.nl>
To: The development of GRUB 2 <grub-devel@gnu.org>
References: <473230F2.6040305@t-online.de> <87ejezla2g.fsf@xs4all.nl>
	<47359EDE.2000102@t-online.de>
Mail-Copies-To: mgerards@xs4all.nl
Date: Sat, 10 Nov 2007 16:27:28 +0100
In-Reply-To: <47359EDE.2000102@t-online.de> (Christian Franke's message of
	"Sat, 10 Nov 2007 13:06:54 +0100")
Message-ID: <87tznui0in.fsf@xs4all.nl>
User-Agent: Gnus/5.110006 (No Gnus v0.6) Emacs/21.4 (gnu/linux)
MIME-Version: 1.0
Content-Type: text/plain; charset=us-ascii
X-Virus-Scanned: by XS4ALL Virus Scanner
X-detected-kernel: by monty-python.gnu.org: FreeBSD 4.6-4.9
Subject: Re: [PATCH] Avoid crash on empty menu
X-BeenThere: grub-devel@gnu.org
X-Mailman-Version: 2.1.5
Precedence: list
Reply-To: The development of GRUB 2 <grub-devel@gnu.org>
List-Id: The development of GRUB 2 <grub-devel.gnu.org>
List-Unsubscribe: <http://lists.gnu.org/mailman/listinfo/grub-devel>,
	<mailto:grub-devel-request@gnu.org?subject=unsubscribe>
List-Archive: <http://lists.gnu.org/pipermail/grub-devel>
List-Post: <mailto:grub-devel@gnu.org>
List-Help: <mailto:grub-devel-request@gnu.org?subject=help>
List-Subscribe: <http://lists.gnu.org/mailman/listinfo/grub-devel>,
	<mailto:grub-devel-request@gnu.org?subject=subscribe>
X-List-Received-Date: Sat, 10 Nov 2007 15:27:00 -0000

Christian Franke <Christian.Franke@t-online.de> writes:

> Marco Gerards wrote:
>>
>>> +      e = get_entry (menu, boot_entry);
>>> +      if (! e)
>>> +	continue; /* menu is empty */
>>>
>>
>> Please use proper interpunctions for comments.
>>
>>
>
> Fixed.
>
> Christian
>
> 2007-11-10  Christian Franke  <franke@computer.org>
>
> 	* normal/menu.c (run_menu): Check for empty menu to avoid crash.
> 	(grub_menu_run): Likewise.

This looks ok to me.  We can apply this now, it's just a few line.

--
Marco